From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 10:28:25 -0400 Message-ID: References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <875ymt70jl.fsf@fastmail.fm> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55149-done@debbugs.gnu.org, No Wayman , Juri Linkov To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 16:29:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk59F-0004H0-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 16:29:37 +0200 Original-Received: from localhost ([::1]:58034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk59E-000050-H3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 10:29:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk58g-0007yS-SU for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk58g-0004Ja-JP for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk58g-0003Ea-G6 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55149-done@debbugs.gnu.org id=D55149.165115611712387 (code D ref 55149); Thu, 28 Apr 2022 14:29:02 +0000 Original-Received: (at 55149-done) by debbugs.gnu.org; 28 Apr 2022 14:28:37 +0000 Original-Received: from localhost ([127.0.0.1]:49521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk58G-0003Dh-R6 for submit@debbugs.gnu.org; Thu, 28 Apr 2022 10:28:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk58F-0003DV-HE for 55149-done@debbugs.gnu.org; Thu, 28 Apr 2022 10:28:36 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6E87F10027D; Thu, 28 Apr 2022 10:28:29 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F092B100164; Thu, 28 Apr 2022 10:28:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651156107; bh=iG4v8xpKtiTI3YaAOyTlEZBEYEGvGuL0nnNfdIdPN5s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fpNb3kZutJsfPxgTBceeIQNt5eo3d+WB6Wy4Jquh0TC1+sg5VOkoiwZbdfI9gS2Gz XurewnK4gUsv7544LtiFIQ9dpMZW16iWM6LtkceK7dKQpyuCwiVraxSyMF5R8vRTt5 viIEXFr4q4CDvVufNp6TG2WoJ4YvvUQSsDISkAgEgwkLjmZEepBH2keC7i2l1lsMnB MazysXBlHPdwNB5oR/o144eZOvQMh1/nB7BP0CCh2URnG6CiTeJsYsdxvlM+nKDgZL JHUkTgPhLcHsatN7pEH4yttZRNDfHfSfcBhYgduPZ22NhbYVIgQVVE+JsA5Vmoyg1F o6OYXMo7W57LA== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B07D41204FE; Thu, 28 Apr 2022 10:28:27 -0400 (EDT) In-Reply-To: <875ymt70jl.fsf@fastmail.fm> (Tassilo Horn's message of "Thu, 28 Apr 2022 16:14:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230884 Archived-At: > It is, thanks. Shouldn't you also adapt the add-function docstring? > Oh, that's adapted automatically! Interesting approach. :-) Actually, it was done to avoid copy&paste between the docstrings of `add-function` and `advice-add`, but it's nice that it also avoids duplication between the code and the doc and makes sure the doc is in sync with the code. Stefan