From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Fri, 05 May 2023 16:30:28 -0400 Message-ID: References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87a5zhmexh.fsf@catern.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62732@debbugs.gnu.org To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 22:31:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pv25O-0007IT-6E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 22:31:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pv254-0005Yf-BE; Fri, 05 May 2023 16:31:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pv250-0005YN-0O for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pv24z-0005oO-Oj for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pv24z-0006ni-KZ for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 16:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 20:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.168331864226114 (code B ref 62732); Fri, 05 May 2023 20:31:01 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 5 May 2023 20:30:42 +0000 Original-Received: from localhost ([127.0.0.1]:57632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv24g-0006n7-4M for submit@debbugs.gnu.org; Fri, 05 May 2023 16:30:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pv24d-0006ms-4t for 62732@debbugs.gnu.org; Fri, 05 May 2023 16:30:40 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7049A442D2C; Fri, 5 May 2023 16:30:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0342A442D1F; Fri, 5 May 2023 16:30:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1683318632; bh=kjXlyhYg9gg0DHikRCmEHwawTwoWV/pIhWJaqGLBjxA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oQqlrnLzYSIqsQvv5zPgTCGzFTguYe7E32cpTs/ZVhiPNdrMpPcYvdt3niiprMJGa 0NtBxo0hluTpc4i80+q0nP7jN81EpIe6OhxtdFLPhVpjHIrEq1CMhscL6rMWz8ycDq gFQ4XwSfmLuzDljwAraCurUYBMV32hRnP4o0FGpUN7dmmqpr6//U6B02kQuEd6uLwn IUmV4TWMWK4x0fJZ6ShttFvotJKJAgm5aCbSz2Hy4Rm1xAQjJkWqnIrDenBFVzXa8y dpcX1B8pRD+Aj/+qDN88mQVtAvsCGVM3bNS2J8Ijf01HhT1AWtW3Yn62odLF0w2Ami uJrj+ehUWDKYw== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A85931204BA; Fri, 5 May 2023 16:30:31 -0400 (EDT) In-Reply-To: <87a5zhmexh.fsf@catern.com> (sbaugh@catern.com's message of "Sun, 09 Apr 2023 12:13:31 +0000 (UTC)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261143 Archived-At: > Ah, while I'm at it, here's a fix (based on the patch in the preceding > mail) for a different bug which I just noticed: create-file-buffer's > documentations states: > >>Emacs treats buffers whose names begin with a space as internal buffers. >>To avoid confusion when visiting a file whose name begins with a space, >>this function prepends a "|" to the final result if necessary. > > But uniquify renames the buffer away from having that "|". This patch > fixes that bug. How 'bout the patch below (based on the current code), instead? Stefan diff --git a/lisp/uniquify.el b/lisp/uniquify.el index dee9ecba2ea..c252d5461aa 100644 --- a/lisp/uniquify.el +++ b/lisp/uniquify.el @@ -498,7 +498,7 @@ uniquify--create-file-buffer-advice (when uniquify-buffer-name-style (let ((filename (expand-file-name (directory-file-name filename)))) (uniquify-rationalize-file-buffer-names - (file-name-nondirectory filename) + (buffer-name buf) (file-name-directory filename) buf))))