From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice. Date: Mon, 22 May 2023 11:04:46 -0400 Message-ID: References: <4ACD9E26-B5A6-412E-8DFC-C09C05A4EACD@mac.com> <871qj8lp8u.fsf@gmail.com> <87bkicjvne.fsf@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7976"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , 63625@debbugs.gnu.org, todd smith To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 17:05:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q176Q-0001qs-RE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 17:05:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q175z-0003U0-2g; Mon, 22 May 2023 11:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q175s-0003S5-AZ for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q175q-0003TO-PN for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q175q-0004A0-Kc for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63625 X-GNU-PR-Package: emacs Original-Received: via spool by 63625-submit@debbugs.gnu.org id=B63625.168476789815964 (code B ref 63625); Mon, 22 May 2023 15:05:02 +0000 Original-Received: (at 63625) by debbugs.gnu.org; 22 May 2023 15:04:58 +0000 Original-Received: from localhost ([127.0.0.1]:35801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q175m-00049Q-3T for submit@debbugs.gnu.org; Mon, 22 May 2023 11:04:58 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q175j-00049B-TH for 63625@debbugs.gnu.org; Mon, 22 May 2023 11:04:56 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4C25744120A; Mon, 22 May 2023 11:04:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0687244124E; Mon, 22 May 2023 11:04:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1684767889; bh=7AFEfCHTiC0XqguxUxqjVJiYftfTeuatxAXJQTN3RHI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Qx7xjSqq33oXzb0hhsc8+RH1Tkd1sVy+1/bHcJOjHuGK5/3IUMhsdngM6vIpkX/4z 18VfD2auI1OuYRNgqZXyTYgOeWbfjRy6URvVZA3HQVH8ERQkQFAsm5CX6X2JC2YUPp 4Gm2GpXWqeXH6q/rt6w0DPD5ltnbOlKdMfeZk+lr+WNpWc5LG+uA23HmgkImEvS5jz 5J8I4MnVJNhb9y2VCbhGKMX1/RDkca1EE0YvP3VxCHosciJnx/1DhQylIjHhPOSyIJ uddY34rDMQpFU8PqdNRwNE85Dd4NKonrLfr5kH6g9oaCbpA0oaMWDRSjoqtW/si6RP Gn5PXAGjQKpAQ== Original-Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BE1851202BB; Mon, 22 May 2023 11:04:48 -0400 (EDT) In-Reply-To: <87bkicjvne.fsf@gmail.com> (Robert Pluim's message of "Mon, 22 May 2023 16:19:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262161 Archived-At: > `file-name-directory' will return nil for names with no slashes in > them, but I don=CA=BCt know if that=CA=BCs possible here. I think `load-file-name` is always absolute, so I think we should be safe, but that's the question, yes. > I *think* we can use `when-let*' here, since subr.el is preloaded. Please don't, it's too recently introduced IMO and such generated files may be loaded in older Emacsen. > Stefan> (package--reload-previously-loaded pkg-desc)) > Stefan> (with-demoted-errors "Error loading autoloads: %s" > Stefan> (load (package--autoloads-file-name pkg-desc) nil = t)) > Stefan> - (add-to-list 'load-path (directory-file-name pkg-dir= ))) > Stefan> + ;; FIXME: Since 2013 (commit 4fac34cee97a), the auto= load files take > Stefan> + ;; care of changing the `load-path', so maybe it's t= ime to > Stefan> + ;; remove this fallback code? > Stefan> + (unless (or (member (file-name-as-directory pkg-dir)= load-path) > Stefan> + (member (directory-file-name pkg-dir) lo= ad-path)) > Stefan> + (add-to-list 'load-path pkg-dir))) Maybe we can have that patch in emacs-29 and remove the code altogether on `master`? Stefan