From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#451: 23.0.60; x-gtk-map-stock destroys match data Date: Fri, 20 Jun 2008 10:28:30 -0400 Message-ID: References: <20080620023825.6AED48FC6D@kahikatea.snap.net.nz> Reply-To: Stefan Monnier , 451@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213973271 7362 80.91.229.12 (20 Jun 2008 14:47:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Jun 2008 14:47:51 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 451@emacsbugs.donarmstrong.com To: Nick Roberts Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 20 16:48:35 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K9huZ-0003O3-Bd for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jun 2008 16:48:23 +0200 Original-Received: from localhost ([127.0.0.1]:52329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K9htg-0007Hq-6G for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jun 2008 10:47:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K9htc-0007HS-7x for bug-gnu-emacs@gnu.org; Fri, 20 Jun 2008 10:47:24 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K9htZ-0007F7-IC for bug-gnu-emacs@gnu.org; Fri, 20 Jun 2008 10:47:23 -0400 Original-Received: from [199.232.76.173] (port=33301 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K9htZ-0007F2-D9 for bug-gnu-emacs@gnu.org; Fri, 20 Jun 2008 10:47:21 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42858) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K9htX-0001eR-9s for bug-gnu-emacs@gnu.org; Fri, 20 Jun 2008 10:47:19 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5KEl9ZY018343; Fri, 20 Jun 2008 07:47:09 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m5KEZ53f014992; Fri, 20 Jun 2008 07:35:05 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 20 Jun 2008 14:35:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 451 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 451-submit@emacsbugs.donarmstrong.com id=B451.121397212213623 (code B ref 451); Fri, 20 Jun 2008 14:35:05 +0000 Original-Received: (at 451) by emacsbugs.donarmstrong.com; 20 Jun 2008 14:28:42 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5KESchR013610 for <451@emacsbugs.donarmstrong.com>; Fri, 20 Jun 2008 07:28:39 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AicFAANcW0jO+KWv/2dsb2JhbACBW64i X-IronPort-AV: E=Sophos;i="4.27,679,1204520400"; d="scan'208";a="23014154" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 20 Jun 2008 10:28:31 -0400 Original-Received: from pastel.home ([206.248.165.175]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id AUW23431; Fri, 20 Jun 2008 10:28:31 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CC9F57F05; Fri, 20 Jun 2008 10:28:30 -0400 (EDT) In-Reply-To: <20080620023825.6AED48FC6D@kahikatea.snap.net.nz> (Nick Roberts's message of "Fri, 20 Jun 2008 14:38:25 +1200 (NZST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-CrossAssassin-Score: 2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Fri, 20 Jun 2008 10:47:23 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18463 gmane.emacs.pretest.bugs:22658 Archived-At: > In the event loop (?), update_frame_tool_bar calls x-gtk-map-stock (in > x-win.el) which uses string-match. This changes the match data that > I need for my application. I don't know what the rules are about > using string-match from C code but as a minimum x-gtk-map-stock should > wrap save-match-data around the call to it. The match-data is a very volatile piece of data. So while you may be right, I think it's more likely that the problem is in your code (i.e., your code should save the match-data itself if it needs to use it after some non-trivial code has been run, and by "trivial" I *really* mean trivial). Stefan