From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Sun, 17 May 2009 16:43:54 -0400 Message-ID: References: <2C87549A-2553-4477-BF77-6258A1CC32BE@gmail.com> <6A510E91-6262-44CF-AA62-315DECB52EF6@gmail.com> Reply-To: Stefan Monnier , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242593632 8520 80.91.229.12 (17 May 2009 20:53:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 May 2009 20:53:52 +0000 (UTC) Cc: 3303@emacsbugs.donarmstrong.com, Adrian Robert To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 17 22:53:45 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M5nMe-0002Dn-I1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 May 2009 22:53:44 +0200 Original-Received: from localhost ([127.0.0.1]:55268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5nMe-0008Up-0w for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 May 2009 16:53:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M5nL7-0006wr-2d for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 16:52:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M5nL1-0006s5-6n for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 16:52:07 -0400 Original-Received: from [199.232.76.173] (port=43511 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M5nL0-0006rs-Pg for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 16:52:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38516) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M5nL0-000205-0f for bug-gnu-emacs@gnu.org; Sun, 17 May 2009 16:52:02 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4HKpuSM003051; Sun, 17 May 2009 13:51:57 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4HKo9m1001953; Sun, 17 May 2009 13:50:09 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 17 May 2009 20:50:08 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3303-submit@emacsbugs.donarmstrong.com id=B3303.1242593044336 (code B ref 3303); Sun, 17 May 2009 20:50:08 +0000 Original-Received: (at 3303) by emacsbugs.donarmstrong.com; 17 May 2009 20:44:04 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4HKi0Rl000328 for <3303@emacsbugs.donarmstrong.com>; Sun, 17 May 2009 13:44:02 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvAFAHcTEEpMCovv/2dsb2JhbACBTs1ihAEFhWo X-IronPort-AV: E=Sophos;i="4.41,208,1241409600"; d="scan'208";a="38713280" Original-Received: from 76-10-139-239.dsl.teksavvy.com (HELO ceviche.home) ([76.10.139.239]) by ironport2-out.teksavvy.com with ESMTP; 17 May 2009 16:43:55 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A7150B41E3; Sun, 17 May 2009 16:43:54 -0400 (EDT) In-Reply-To: <6A510E91-6262-44CF-AA62-315DECB52EF6@gmail.com> (David Reitter's message of "Sun, 17 May 2009 15:12:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 17 May 2009 16:52:07 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27944 Archived-At: >> Still, the >> >> #ifdef NS_IMPL_COCOA >> /* term gets no other notification of this */ >> if (for_deletion) >> Fraise_frame(Qnil); >> #endif >> >> in frame.c looks plain wrong and should probably just be deleted: >> frame-selection is never intended to raise (or lower) any frame. >> If this `raise' is really necessary, then it needs a much more extensive >> comment justifying its presence. >> Adrian, could you remove this code, or justify clearly why it's here? > I think it is there because we need to raise another (visible) frame when > a frame is deleted. This is standard behavior (and sensible). This is a behavior which depends on the window-management policy, so it's the responsibility of the window-manager (which may even decide that the focus should return to some other application, which would make a lot of sense if the frame was created via $EDITOR=emacsclient). So, I'd still want to know what undesirable behavior would happen under NS if we don't call Fraise_frame here (and also, why it needs to be called here rather than elsewhere). Stefan