bug#5768: 23.1; ModelSim and compile.el

bug#5768: 23.1; ModelSim and compile.el

[Scott, Ashley]

[-- Attachment #1: Type: text/plain, Size: 3090 bytes --]

It appears that the latest version of compile.el does not correctly
parse the

error messages from ModelSim. The (compile.elc) file shipped with emacs
version

21.3 does correctly parse the ModelSim error messages.

 

 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)

 of 2009-07-30 on SOFT-MJASON

Windowing system distributor `Microsoft Corp.', version 5.1.2600

configured using `configure --with-gcc (4.4)'

 

Important settings:

  value of $LC_ALL: nil

  value of $LC_COLLATE: nil

  value of $LC_CTYPE: nil

  value of $LC_MESSAGES: nil

  value of $LC_MONETARY: nil

  value of $LC_NUMERIC: nil

  value of $LC_TIME: nil

  value of $LANG: ENU

  value of $XMODIFIERS: nil

  locale-coding-system: cp1252

  default-enable-multibyte-characters: t

 

Major mode: VHDL/es

 

Minor modes in effect:

  diff-auto-refine-mode: t

  display-time-mode: t

  delete-selection-mode: t

  show-paren-mode: t

  pc-selection-mode: t

  tooltip-mode: t

  tool-bar-mode: t

  mouse-wheel-mode: t

  menu-bar-mode: t

  file-name-shadow-mode: t

  global-font-lock-mode: t

  font-lock-mode: t

  blink-cursor-mode: t

  global-auto-composition-mode: t

  auto-composition-mode: t

  auto-encryption-mode: t

  auto-compression-mode: t

  line-number-mode: t

  transient-mark-mode: t

  hs-minor-mode: t

 

Recent input:

<drag-n-drop> C-c C-M-k <return> <help-echo> <help-echo> 

<down-mouse-1> <mouse-1> <double-down-mouse-1> <double-mouse-1> 

<down-mouse-1> <mouse-1> <return> <wheel-up> <help-echo> 

<down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1> <double-down-mouse-1> 

<double-mouse-1> <help-echo> <down-mouse-1> <mouse-1> 

<double-down-mouse-1> <double-mouse-1> <triple-down-mouse-1> 

<triple-mouse-1> <help-echo> <down-mouse-1> <mouse-1> 

<double-down-mouse-1> <double-mouse-1> <triple-down-mouse-1> 

<triple-mouse-1> <help-echo> <down-mouse-1> <mouse-1> 

<double-down-mouse-1> <double-mouse-1> <triple-down-mouse-1> 

<triple-mouse-1> <triple-down-mouse-1> <triple-mouse-1> 

<help-echo> <help-echo> <down-mouse-1> <mouse-1> <C-home> 

<help-echo> C-x ` <help-echo> <mouse-1> <help-echo> 

<help-echo> <help-echo> <menu-bar> <VHDL> <Compile> 

<First Error> <right> <right> <right> <right> <right> 

<right> <right> <right> <right> <right> <right> <right> 

<right> <right> <right> <right> <left> <backspace> 

C-x C-s C-c C-M-k <return> <help-echo> <help-echo> 

<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 

<help-echo> <menu-bar> <help-menu> <send-emacs-bug

-report>

 

Recent messages:

Scanning directory for source files ...

VHDL Mode 3.33.26.  See menu for documentation and release notes.

(No files need saving)

Parsing error messages...done.

Mark set [2 times]

Parsing error messages...done.

Mark set

Saving file c:/lab/vhdl/syslog.vhd...

Wrote c:/lab/vhdl/syslog.vhd

(No files need saving)

*** E-Mail body has been placed on clipboard, please paste them here!
*** 


[-- Attachment #2: Type: text/html, Size: 13709 bytes --]

bug#5768: 23.1; ModelSim and compile.el

[Stefan Monnier]

> It appears that the latest version of compile.el does not correctly
> parse the error messages from ModelSim. The (compile.elc) file shipped
> with emacs version 21.3 does correctly parse the ModelSim
> error messages.

Could you show us some sample error messages that Emacs fails to match? 


        Stefan

bug#5768: 23.1; ModelSim and compile.el

[Scott, Ashley]

[-- Attachment #1.1: Type: text/plain, Size: 843 bytes --]

Please notice that the error message below is not highlighted using the
newer version of compile.el.

 

 

 

The following is what happens when I use the older version of
compile.elc:

 

 

 

Thanks for looking into this.

 

A. Scott

 

-----Original Message-----
From: Stefan Monnier [mailto:monnier@iro.umontreal.ca] 
Sent: Wednesday, March 24, 2010 4:59 PM
To: Scott, Ashley
Cc: 5768@debbugs.gnu.org
Subject: Re: bug#5768: 23.1; ModelSim and compile.el

 

> It appears that the latest version of compile.el does not correctly

> parse the error messages from ModelSim. The (compile.elc) file shipped

> with emacs version 21.3 does correctly parse the ModelSim

> error messages.

 

Could you show us some sample error messages that Emacs fails to match? 

 

 

        Stefan


[-- Attachment #1.2: Type: text/html, Size: 5032 bytes --]

[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 79004 bytes --]

[-- Attachment #3: image002.jpg --]
[-- Type: image/jpeg, Size: 65254 bytes --]

bug#5768: vhdl-mode.el: modelsim error parsing does not work. Patch attached.

[Friedrich Beckmann]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Control: Tags -1 patch 

Hi,

I can confirm that the problem with modelsim error parsing in VHDL mode is still there
in Ubuntu 14.04 with Emacs version 24.3.1 and vhdl-mode.el from the current gnu emacs
repository and also the original ubuntu vhdl-mode.elc version 3.33.28. 

I fixed the problem by modifying vhdl-mode.el file from the current repository. The patch is attached. 
By the way, the upstream link:

http://www.iis.ee.ethz.ch/~zimmi

is a dead link today. Attached are two pictures showing emacs before and after the fix and the patch of vhdl-mode.el. 

Friedrich

















[-- Attachment #2.1: Type: text/html, Size: 1076 bytes --]

[-- Attachment #2.2: vhdl-compilation-before-fix.JPG --]
[-- Type: image/JPG, Size: 214831 bytes --]

[-- Attachment #2.3: Type: text/html, Size: 271 bytes --]

[-- Attachment #2.4: vhdl-compilation-after-fix.JPG --]
[-- Type: image/JPG, Size: 215702 bytes --]

[-- Attachment #2.5: Type: text/html, Size: 241 bytes --]

[-- Attachment #2.6: vhdl-mode-modelsim-error-parsing.patch --]
[-- Type: application/octet-stream, Size: 1248 bytes --]

diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index 3d5a398..7c51587 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -264,9 +264,14 @@ Overrides local variable `indent-tabs-mode'."
     ;; WARNING[2]: test.vhd(85): Possible infinite loop
     ;; ** Warning: [4] ../src/emacsvsim.vhd(43): An abstract ...
     ;; ** Error: adder.vhd(190): Unknown identifier: ctl_numb
+    ;; ** Error: counter_rtl.vhd(18): Nonresolved signal 'hallo' has multiple sources.
+    ;;  Drivers:
+    ;;    counter_rtl.vhd(27):Conditional signal assignment line__27
+    ;;    counter_rtl.vhd(29):Conditional signal assignment line__29
     ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1"
      nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim"
-     ("\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\[[0-9]+\]\\)? \\([^ \\t\\n]+\\)(\\([0-9]+\\)):" 3 4 nil) ("" 0)
+     ("\\(ERROR:\\|WARNING\\[[0-9]+\\]:\\|\\*\\* Error:\\|\\*\\* Warning: \\[[0-9]+\\]\\| +\\) \\([^ ]+\\)(\\([0-9]+\\)):" 2 3 nil)
+     ("" 0)
      ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat"
       "\\1/_primary.dat" "\\1/body.dat" downcase))
     ;; ProVHDL, Synopsys LEDA: provhdl -w work -f test.vhd

[-- Attachment #2.7: Type: text/html, Size: 838 bytes --]

bug#5768: Bug 5768: vhdl-mode.el: Modelsim error parsing patch in plain text

[Friedrich Beckmann]

I attach the patch in plain text also:

diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
index 3d5a398..7c51587 100644
--- a/lisp/progmodes/vhdl-mode.el
+++ b/lisp/progmodes/vhdl-mode.el
@@ -264,9 +264,14 @@ Overrides local variable `indent-tabs-mode'."
     ;; WARNING[2]: test.vhd(85): Possible infinite loop
     ;; ** Warning: [4] ../src/emacsvsim.vhd(43): An abstract ...
     ;; ** Error: adder.vhd(190): Unknown identifier: ctl_numb
+    ;; ** Error: counter_rtl.vhd(18): Nonresolved signal 'hallo' has multiple sources.
+    ;;  Drivers:
+    ;;    counter_rtl.vhd(27):Conditional signal assignment line__27
+    ;;    counter_rtl.vhd(29):Conditional signal assignment line__29
     ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1"
      nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim"
-     ("\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\[[0-9]+\]\\)? \\([^ \\t\\n]+\\)(\\([0-9]+\\)):" 3 4 nil) ("" 0)
+     ("\\(ERROR:\\|WARNING\\[[0-9]+\\]:\\|\\*\\* Error:\\|\\*\\* Warning: \\[[0-9]+\\]\\| +\\) \\([^ ]+\\)(\\([0-9]+\\)):" 2 3 nil)
+     ("" 0)
      ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat"
       "\\1/_primary.dat" "\\1/body.dat" downcase))
     ;; ProVHDL, Synopsys LEDA: provhdl -w work -f test.vhd

bug#5768: Bug 5768: vhdl-mode.el: Modelsim error parsing patch in plain text

[Lars Ingebrigtsen]

Friedrich Beckmann <friedrich.beckmann@gmx.de> writes:

> I attach the patch in plain text also:
>
> diff --git a/lisp/progmodes/vhdl-mode.el b/lisp/progmodes/vhdl-mode.el
> index 3d5a398..7c51587 100644
> --- a/lisp/progmodes/vhdl-mode.el
> +++ b/lisp/progmodes/vhdl-mode.el
> @@ -264,9 +264,14 @@ Overrides local variable `indent-tabs-mode'."
>      ;; WARNING[2]: test.vhd(85): Possible infinite loop
>      ;; ** Warning: [4] ../src/emacsvsim.vhd(43): An abstract ...
>      ;; ** Error: adder.vhd(190): Unknown identifier: ctl_numb
> +    ;; ** Error: counter_rtl.vhd(18): Nonresolved signal 'hallo' has multiple sources.
> +    ;;  Drivers:
> +    ;;    counter_rtl.vhd(27):Conditional signal assignment line__27
> +    ;;    counter_rtl.vhd(29):Conditional signal assignment line__29
>      ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1"
>       nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim"
> -     ("\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\[[0-9]+\]\\)? \\([^ \\t\\n]+\\)(\\([0-9]+\\)):" 3 4 nil) ("" 0)
> +     ("\\(ERROR:\\|WARNING\\[[0-9]+\\]:\\|\\*\\* Error:\\|\\*\\* Warning: \\[[0-9]+\\]\\| +\\) \\([^ ]+\\)(\\([0-9]+\\)):" 2 3 nil)
> +     ("" 0)
>       ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat"
>        "\\1/_primary.dat" "\\1/body.dat" downcase))
>      ;; ProVHDL, Synopsys LEDA: provhdl -w work -f test.vhd

I don't have ModelSim, so I can't really test this, but at first glance,
this looks reasonable, so I've applied it to emacs-25.

Please reopen this bug if this doesn't fix the problem.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#5768: 23.1; ModelSim and compile.el

[Stefan Monnier]

> Is there any word on the issue about ModelSim and compile.el?

Good question.  Your email didn't seem to contain any actual sample and
I failed to get back to you about it, so it got stuck.  Looking at it
again, I see that you used HTML email and that's why I didn't see
the samples.

Now, I tried your example with Emacs-21.4 but couldn't make `compile' to
highlight your error like you have in your image002.jpg.

I see that vhdl-mode has some code to tweak the error-formats accepted
by compile.el, so maybe the change has to do with vhdl-mode.el.  So in
order to know how/where best to fix the problem, it would be good if you
could help us reproduce the right behavior under Emacs-21.

Here's what I tried:

   emacs21 -q ~/tmp/foo.vhdl
   M-x vhdl-compile RET

with a "vcom" script in my PATH which does:

   #!/bin/sh
   echo "** Error: syslog.vhd(165): near \"_\": expecting \"IS\" or ';'"

and the result is a *compilation* buffer that contains:

   cd /home/monnier/tmp/
   vcom /home/monnier/tmp/foo.vhdl
   ** Error: syslog.vhd(165): near "_": expecting "IS" or ';'
   
   Compilation finished at Thu Sep 16 15:05:56

and no errors are recognized there.  Could you try and find the
difference between my testcase and yours that lets your Emacs-21.3
recognize that message?


        Stefan