From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6256: 24.0.50; read-event in `repeat' command Date: Tue, 19 Oct 2010 16:54:40 -0400 Message-ID: References: <058F2FC300154C1AB894694655B2A968@us.oracle.com> <90A72397ABF34D84A3ACB3B6DE18F74A@us.oracle.com> <0658C0CCC79D466BA9DE233F5980CAE5@us.oracle.com> <8E5430CB43B84B91BB47DB3C0C710C44@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1287522767 10392 80.91.229.12 (19 Oct 2010 21:12:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 19 Oct 2010 21:12:47 +0000 (UTC) Cc: 6256@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 19 23:12:46 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P8JUD-0007EG-EE for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Oct 2010 23:12:45 +0200 Original-Received: from localhost ([127.0.0.1]:44999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8JUC-0003Xe-Os for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Oct 2010 17:12:44 -0400 Original-Received: from [140.186.70.92] (port=58405 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8JU6-0003XR-Tc for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 17:12:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8JU5-0002FR-Qt for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 17:12:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8JU5-0002FN-O2 for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2010 17:12:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P8J9B-0004vl-Ox; Tue, 19 Oct 2010 16:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2010 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6256-submit@debbugs.gnu.org id=B6256.128752145918947 (code B ref 6256); Tue, 19 Oct 2010 20:51:01 +0000 Original-Received: (at 6256) by debbugs.gnu.org; 19 Oct 2010 20:50:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8J99-0004vY-3W for submit@debbugs.gnu.org; Tue, 19 Oct 2010 16:50:59 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P8J96-0004vS-KF for 6256@debbugs.gnu.org; Tue, 19 Oct 2010 16:50:57 -0400 Original-Received: from faina.iro.umontreal.ca (vpn-132-204-232-129.acd.umontreal.ca [132.204.232.129]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o9JKsfRK019123; Tue, 19 Oct 2010 16:54:41 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 9E3E0B4007; Tue, 19 Oct 2010 16:54:40 -0400 (EDT) In-Reply-To: <8E5430CB43B84B91BB47DB3C0C710C44@us.oracle.com> (Drew Adams's message of "Tue, 19 Oct 2010 12:21:04 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3653=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 19 Oct 2010 16:51:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40995 Archived-At: > 1. > Yes, tho the only change it requires is to change the lets into setqs. > Including the let-binding of `repeat-message-function'? I assume not. > Doing that would change the value globally from then on. I've left > that one as a let binding. Good. > 2. However, you say that your implementation will anyway render a let > binding of `repeat-message-function' ineffective. Do you mean your > current fix using read-key or your future reimplementation that you > have locally? I mean my future reimplementation. > I assume you mean the latter. I can't test that, so I can't say how annoying > the changed message behavior would be. Don't worry about it: it's a problem for me, as of now. > It seems like your future replacement would change the notion of > a repetition so that it no longer does everything that is currently > done in `repeat' (since `repeat' is not called repetitively). Dunno. It changes the place where the loop happens, yes: insteads of calling repeat repetitively from repeat itself, it's called repetitively from the toplevel command loop. > I realize you are still working on it, but please try not to sacrifice > too much in your quest for simplicity. It's not for simplicity but for correctness (several corner cases fail to work with read-key/event/char). > 3. Your current read-key fix for `repeat' does not work in Emacs 23, > whereas my fix using read-event does work. I did not understand that from your answer and I'm very surprised, since AFAIK this part of Emacs hasn't changed significantly. In any case I've only tested it under Emacs-23 (yup, that's a 3 there). > But maybe I will be if I understand its advantages. What was your > objection to the solution I provided using `read-event'? You never > stated it, IIRC. Your characterization of what works and what doesn't makes no sense to me (based on my understand of what the code does, and based on my tests), so I used the code that I know to work and I understand why. Since you say it doesn't work for you, please follow my advice: Please confirm whether or not it fixes it for you, and if it doesn't, please show me the values of `repeat-repeat-char' and `evt' in the above test. because without that info from your tests, I can't help you much further. Stefan