From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#114: Shell-mode: File completion breaks editing previous commands Date: Wed, 12 Oct 2011 08:39:40 -0400 Message-ID: References: <87tzig9es5.fsf@stupidchicken.com> <18424.40053.181304.491320@lusitania.rswheeldon.com> <878wzq2qtv.fsf@stupidchicken.com> <18428.43150.358991.358580@rgrjr.rgrjr.dyndns.org> <20096.38009.370949.709474@maryrose.rswheeldon.com> <55hb3ph4yc.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1318423251 15608 80.91.229.12 (12 Oct 2011 12:40:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 12 Oct 2011 12:40:51 +0000 (UTC) Cc: 114@debbugs.gnu.org, Miles Bader To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 12 14:40:46 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RDy74-0000jy-5X for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2011 14:40:46 +0200 Original-Received: from localhost ([::1]:46677 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDy72-0005aH-Ve for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Oct 2011 08:40:44 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDy6z-0005a1-Un for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2011 08:40:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RDy6y-0002Oh-PA for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2011 08:40:41 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RDy6y-0002Od-NV for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2011 08:40:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RDy7K-0008C2-D7 for bug-gnu-emacs@gnu.org; Wed, 12 Oct 2011 08:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Oct 2011 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 114-submit@debbugs.gnu.org id=B114.131842321231433 (code B ref 114); Wed, 12 Oct 2011 12:41:02 +0000 Original-Received: (at 114) by debbugs.gnu.org; 12 Oct 2011 12:40:12 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDy6V-0008Av-AI for submit@debbugs.gnu.org; Wed, 12 Oct 2011 08:40:12 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RDy6T-0008Ah-36 for 114@debbugs.gnu.org; Wed, 12 Oct 2011 08:40:09 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAP6JlU5FxJoX/2dsb2JhbABDqC6BBoFTAQEEAVYjBQsLDiYSFBgNJC6HY7l0h1gEoSCERQ X-IronPort-AV: E=Sophos;i="4.69,334,1315195200"; d="scan'208";a="141401597" Original-Received: from 69-196-154-23.dsl.teksavvy.com (HELO pastel.home) ([69.196.154.23]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 12 Oct 2011 08:39:41 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C979A5933F; Wed, 12 Oct 2011 08:39:40 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Wed, 12 Oct 2011 01:27:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 12 Oct 2011 08:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52581 Archived-At: >> But that's also the case before my patch, right? So it's not >> a consequence of my patch. > OK then, pretend I said: > I'm also not sure what consequences simply removing this field property > will have. > However, I noticed that your patch leaves the help-echo and mouse-face > properties missing on the completed text, which is a little unaesthetic. > An alternative solution that avoids this issue would be if callers of > completion could optionally request that it insert-and-inherit the > completed text rather than just insert it. I could imagine that other > callers of completion might need such a feature. But I have no idea if > this is feasible. I think there are two issues: 1- handling the `insert' case as well as possible, because a lot of code uses just `insert' (tho in practice very few cases seem to show up: yank, completion, any other?). 2- changing (some) users of `insert' such as completion to use insert-and-inherit. (2) might be good, indeed, tho I'm not completely sure what are the consequences. Stefan