unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 114@debbugs.gnu.org, Miles Bader <miles@gnu.org>
Subject: bug#114: Shell-mode: File completion breaks editing previous commands
Date: Wed, 12 Oct 2011 08:39:40 -0400	[thread overview]
Message-ID: <jwvr52ie69d.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <rwwrcaeq4a.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 12 Oct 2011 01:27:33 -0400")

>> But that's also the case before my patch, right?  So it's not
>> a consequence of my patch.

> OK then, pretend I said:

> I'm also not sure what consequences simply removing this field property
> will have.

> However, I noticed that your patch leaves the help-echo and mouse-face
> properties missing on the completed text, which is a little unaesthetic.
> An alternative solution that avoids this issue would be if callers of
> completion could optionally request that it insert-and-inherit the
> completed text rather than just insert it. I could imagine that other
> callers of completion might need such a feature. But I have no idea if
> this is feasible.

I think there are two issues:
1- handling the `insert' case as well as possible, because a lot of code
   uses just `insert' (tho in practice very few cases seem to show up:
   yank, completion, any other?).
2- changing (some) users of `insert' such as completion to use
   insert-and-inherit.

(2) might be good, indeed, tho I'm not completely sure what are the consequences.


        Stefan





  reply	other threads:[~2011-10-12 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87tzig9es5.fsf@stupidchicken.com>
     [not found] ` <18424.40053.181304.491320@lusitania.rswheeldon.com>
     [not found]   ` <878wzq2qtv.fsf@stupidchicken.com>
     [not found]     ` <18428.43150.358991.358580@rgrjr.rgrjr.dyndns.org>
2011-09-11  5:23       ` bug#114: Shell-mode: File completion breaks editing previous commands Lars Magne Ingebrigtsen
2011-09-25 13:27         ` Lars Magne Ingebrigtsen
2011-09-26 15:04           ` richard
2011-09-26 19:40             ` Lars Magne Ingebrigtsen
2011-10-03 21:12               ` Glenn Morris
2011-10-04  0:57                 ` Stefan Monnier
2011-10-04  1:51                   ` Glenn Morris
2011-10-04  2:14                   ` Stefan Monnier
2011-10-04  2:21                     ` Glenn Morris
2011-10-12  4:30                       ` Stefan Monnier
2008-04-04 11:39                         ` richard
2011-10-12  5:27                           ` bug#114: " Glenn Morris
2011-10-12 12:39                             ` Stefan Monnier [this message]
2011-10-17 16:34                               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr52ie69d.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=114@debbugs.gnu.org \
    --cc=miles@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).