unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Toby Cubitt <tsc25@cantab.net>
Cc: 12685@debbugs.gnu.org
Subject: bug#12685: 24.2; lexical binding breaks edebug conditional breakpoints
Date: Tue, 23 Oct 2012 12:33:34 -0400	[thread overview]
Message-ID: <jwvr4op6tpk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20121020010835.GA2683@c3po> (Toby Cubitt's message of "Sat, 20 Oct 2012 03:08:35 +0200")

>> The fact that it aborts execution should be fixable before the release
>> (tho I'm not sure that it's really better to silently mis-interpret the
>> user's request),
> Indeed.  But that's what the documentation says it should do, so either
> the documentation or the implementation needs to be changed so that they
> at least match.

I think at this stage the best is to add a note that it might fail when
used for lexical-binding code.

> I figured as much. Maybe for now we could mention in the Edebug section
> of the Elisp manual which parts of edebug won't (currently) work in
> lexically-scoped code? As far as I can see, M-: and conditional
> breakpoints should be the only things that are affected. (Though
> `edebug-step-in' doesn't always seem to work for me lately, but I can't
> reliably reproduce this at the moment.)

Agreed.  Could you take care of it?

> Maybe the docs should even recommend disabling lexical-binding when
> edebugging for now.

I don't think so.  The programmer can reach his own conclusion based on
the text you'll add warning that some parts don't work.

> (Is there a good way of configuring this to happen
> automatically?

No, that would be even worse, since some code only works in
lexical-binding mode (and there's no way to figure out if the code in
the current buffer is in this category).


        Stefan





  reply	other threads:[~2012-10-23 16:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 19:18 bug#12685: 24.2; lexical binding breaks edebug conditional breakpoints Toby Cubitt
2012-10-19 21:41 ` Stefan Monnier
2012-10-20  1:08   ` Toby Cubitt
2012-10-23 16:33     ` Stefan Monnier [this message]
2012-10-23 17:10       ` Toby Cubitt
2012-10-23 18:27         ` Stefan Monnier
2012-10-23 18:39           ` Toby Cubitt
2012-10-24 13:55             ` Stefan Monnier
2013-07-26 16:09 ` Stefan Monnier
2013-08-05 15:14   ` Toby Cubitt
2013-08-05 17:27     ` Stefan Monnier
2013-08-08 23:19     ` Stefan Monnier
2013-08-09 11:02       ` Toby Cubitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr4op6tpk.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=12685@debbugs.gnu.org \
    --cc=tsc25@cantab.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).