From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries Date: Wed, 18 Feb 2015 17:56:21 -0500 Message-ID: References: <87r3txhkz1.fsf@ceis-strat.com> <87twyt5o8q.fsf@mail.linkov.net> <874mqsq6ar.fsf@mail.linkov.net> <87zj8iljfk.fsf@mail.linkov.net> <87r3tnax8h.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424300246 12534 80.91.229.3 (18 Feb 2015 22:57:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2015 22:57:26 +0000 (UTC) Cc: Bastien , 19829@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 18 23:57:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YODYP-0000eV-Pw for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2015 23:57:13 +0100 Original-Received: from localhost ([::1]:54021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YODYP-0005iM-5V for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2015 17:57:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YODYK-0005d1-1W for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 17:57:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YODYF-0004L0-Ax for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 17:57:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YODYF-0004Kj-8U for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 17:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YODYE-00038m-Ce for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 17:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 22:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19829 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19829-submit@debbugs.gnu.org id=B19829.142430021112055 (code B ref 19829); Wed, 18 Feb 2015 22:57:02 +0000 Original-Received: (at 19829) by debbugs.gnu.org; 18 Feb 2015 22:56:51 +0000 Original-Received: from localhost ([127.0.0.1]:48197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YODY2-00038N-R0 for submit@debbugs.gnu.org; Wed, 18 Feb 2015 17:56:51 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:35949) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YODY1-00038C-EF for 19829@debbugs.gnu.org; Wed, 18 Feb 2015 17:56:49 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id ECBE585163; Wed, 18 Feb 2015 17:56:47 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id B2E6E1E5B74; Wed, 18 Feb 2015 17:56:21 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 9A31BB4102; Wed, 18 Feb 2015 17:56:21 -0500 (EST) In-Reply-To: <87r3tnax8h.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 18 Feb 2015 20:30:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99568 Archived-At: > + (lambda (delete &optional positions) No: additional *value*, not additional *argument*. > + (let (start end) > + (move-to-column startcol) > + (setq start (point)) > + (move-to-column endcol) > + (setq end (point)) > + (setcdr positions (cons (cons start end) (cdr positions))))) Aka (move-to-column startcol) (let ((start (point))) (move-to-column endcol) (push (cons start (point)) (cdr positions))) > + (apply-on-rectangle 'extract-rectangle-position ^^^ #' You could also inline this function so as to avoid the dummy (list nil) cell. > + ;; Use local binding in add-function below. > + (isearch-filter-predicate isearch-filter-predicate) > + (rectangular-region-positions nil) replace.el should not know about rectangles and shouldn't check rectangle-mark-mode. It should simply always call region-extract-function to get the various elements that make up the "region". Stefan