From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20365: 24.5; all-completions returns duplicates for Info-read-node-name-1 Date: Sat, 18 Apr 2015 13:41:17 -0400 Message-ID: References: <87egnhfmcd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429378947 18514 80.91.229.3 (18 Apr 2015 17:42:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2015 17:42:27 +0000 (UTC) Cc: 20365@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 18 19:42:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjWkt-0005fW-QV for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2015 19:42:11 +0200 Original-Received: from localhost ([::1]:46413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWkt-0006T5-AD for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2015 13:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWkn-0006Nx-Vs for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjWkk-0002Zo-Qd for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:42:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjWkk-0002Zi-NS for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YjWkk-0003Cd-4b for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2015 13:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Apr 2015 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20365 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20365-submit@debbugs.gnu.org id=B20365.142937888312265 (code B ref 20365); Sat, 18 Apr 2015 17:42:02 +0000 Original-Received: (at 20365) by debbugs.gnu.org; 18 Apr 2015 17:41:23 +0000 Original-Received: from localhost ([127.0.0.1]:60149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjWk6-0003Bl-ST for submit@debbugs.gnu.org; Sat, 18 Apr 2015 13:41:23 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:46204) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YjWk4-0003BX-8p for 20365@debbugs.gnu.org; Sat, 18 Apr 2015 13:41:21 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3IHfH3B032549; Sat, 18 Apr 2015 13:41:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C0CFB13BD; Sat, 18 Apr 2015 13:41:17 -0400 (EDT) In-Reply-To: <87egnhfmcd.fsf@gmail.com> (Oleh Krehel's message of "Sat, 18 Apr 2015 18:11:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5280=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5280> : inlines <2752> : streams <1424625> : uri <1910011> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101683 Archived-At: Just a first comment: it's not considered incorrect for `all-completions' to return a list with duplicate entries in it. More specifically, it's considered the completion UI's job to remove those duplicates. > (setq x (all-completions "(" 'Info-read-node-name-1)) > x will contain many duplicates for each node, like "org" "org" "org" > "org" "org.info.gz" "org" "org.info.gz" "org" "org.info.gz". Maybe the way these entries are generated could be reviewed to try and reduce the number of duplicates. And we could call `delete-dups' on the result: while a completion-table shouldn't need to go out of its way to reduce the number of duplicates (since the UI is supposed to handle it anyway), it's probably good to avoid having such expected large number of duplicates, indeed. > Finally, if one of the elements of `all-completions' is passed, it still > doesn't work. What does "is passed" mean here? What does "doesn't work" mean here? > I'm guessing that it expects "(org)" instead of "org", but > then why not offer these on the completion list? What is "it"? Stefan