From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20472: 24.4; Cannot switch buffers in a dedicated window - report this error earlier Date: Sun, 03 May 2015 21:31:42 -0400 Message-ID: References: <7E039918541B4C4183BFDB8F015C743032E18D99@WCL-EXCH02.wcl.local> <55425888.6080106@gmx.at> <55435866.40006@gmx.at> <5544916C.3020200@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430703144 11525 80.91.229.3 (4 May 2015 01:32:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 May 2015 01:32:24 +0000 (UTC) Cc: 20472@debbugs.gnu.org, Ed Avis To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 04 03:32:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yp5Ey-0005AJ-Sn for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 May 2015 03:32:13 +0200 Original-Received: from localhost ([::1]:60681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5Ey-0004zI-1F for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 May 2015 21:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5Eu-0004z0-OG for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:32:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yp5Ep-0007k0-Qf for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:32:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5Ep-0007jw-NI for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yp5Ep-0004eA-7s for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:32:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 May 2015 01:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20472-submit@debbugs.gnu.org id=B20472.143070311217843 (code B ref 20472); Mon, 04 May 2015 01:32:02 +0000 Original-Received: (at 20472) by debbugs.gnu.org; 4 May 2015 01:31:52 +0000 Original-Received: from localhost ([127.0.0.1]:32873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5Ec-0004di-U6 for submit@debbugs.gnu.org; Sun, 03 May 2015 21:31:51 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5EZ-0004cd-QR for 20472@debbugs.gnu.org; Sun, 03 May 2015 21:31:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCzQSFBgNJIgTohGMcAODPgMDEwSDVgSjY4RYgTcP X-IPAS-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCzQSFBgNJIgTohGMcAODPgMDEwSDVgSjY4RYgTcP X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="118162956" Original-Received: from 69-165-139-108.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.139.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 May 2015 21:31:42 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A4276AE12D; Sun, 3 May 2015 21:31:42 -0400 (EDT) In-Reply-To: <5544916C.3020200@gmx.at> (martin rudalics's message of "Sat, 02 May 2015 10:57:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102430 Archived-At: > At your service. Looks OK, thanks (I'm not 100% sure prompting will turn out to be a good idea, but we can give it a try) Stefan > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -6887,10 +6887,11 @@ WARNING: This is NOT the way to work on another buffer temporarily > within a Lisp program! Use `set-buffer' instead. That avoids > messing with the window-buffer correspondences. > -If the selected window cannot display the specified > -buffer (e.g. if it is a minibuffer window or strongly dedicated > -to another buffer), call `pop-to-buffer' to select the buffer in > -another window. > +If the selected window cannot display the specified buffer > +because it is a minibuffer window or strongly dedicated to > +another buffer, call `pop-to-buffer' to select the buffer in > +another window. In interactive use offer to undedicate the > +selected window before. > If called interactively, read the buffer name using the > minibuffer. The variable `confirm-nonexistent-file-or-buffer' > @@ -6916,7 +6917,15 @@ window. > Return the buffer switched to." > (interactive > - (list (read-buffer-to-switch "Switch to buffer: ") nil 'force-same-window)) > + (let ((force-same-window > + (and (not (window-minibuffer-p)) > + (or (not (eq (window-dedicated-p) t)) > + (and (y-or-n-p > + (format "Window is dedicated to %s; undedicate it" > + (window-buffer))) > + (or (set-window-dedicated-p nil nil) t))) > + 'force-same-window))) > + (list (read-buffer-to-switch "Switch to buffer: ") nil force-same-window))) > (let ((buffer (window-normalize-buffer-to-switch-to buffer-or-name))) > (cond > ;; Don't call set-window-buffer if it's not needed since it