unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 32991@debbugs.gnu.org
Subject: bug#32991: 27.0.50; diff-auto-refine-mode a no-op
Date: Wed, 27 Feb 2019 10:04:35 -0500	[thread overview]
Message-ID: <jwvr2bte0sj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m2lg25upwi.fsf@aurox.ch> (Charles A. Roelli's message of "Sun, 24 Feb 2019 17:12:13 +0100")

> Right, here is the first part.  I noticed another use of
> diff-auto-refine-mode (in admin/gitmerge.el) and its info
> documentation, so I've updated those too.

LGTM.

> Okay, I'm fine with removing the re-narrowing too if there are no
> objections.

No objection from me.

> I'd still like to add a defcustom for the recentering, to allow
> navigation in Diff mode buffers that respects scroll-related
> variables.  But I think I will open a different bug for these issues,
> since this one is nearly fixed.

Yes, let's please first treat it as a bug.  Maybe we won't be able to
fix it without disabling recentering here, in which case we'll add
a defcustom for it, but maybe we can make it recenter *and* obey your
scroll settings at the same time.


        Stefan





  reply	other threads:[~2019-02-27 15:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 18:30 bug#32991: 27.0.50; diff-auto-refine-mode a no-op Charles A. Roelli
2018-10-08 21:00 ` Stefan Monnier
2018-10-09 19:15   ` Charles A. Roelli
2018-10-09 19:54     ` Stefan Monnier
2018-10-10 18:31       ` Charles A. Roelli
2018-10-10 19:21         ` Stefan Monnier
2018-10-13 13:42           ` Charles A. Roelli
2018-10-13 18:51             ` Stefan Monnier
2019-01-13 14:36           ` Charles A. Roelli
2019-01-13 20:03             ` Charles A. Roelli
2019-01-13 23:33               ` Stefan Monnier
2019-01-15 20:25                 ` Charles A. Roelli
2019-02-11 20:14                   ` Stefan Monnier
2019-02-18 19:06                     ` Charles A. Roelli
2019-02-18 20:44                       ` Stefan Monnier
2019-02-24 16:12                         ` Charles A. Roelli
2019-02-27 15:04                           ` Stefan Monnier [this message]
2019-03-03 20:51                             ` Charles A. Roelli
2019-03-05 21:38                               ` Juri Linkov
2019-03-07 19:23                                 ` Charles A. Roelli
2019-01-30 21:04                 ` Juri Linkov
2019-02-01  7:38                   ` Stefan Monnier
2019-02-03 11:42                     ` Charles A. Roelli
2019-02-03 12:37                       ` Stefan Monnier
2019-02-03 14:19                         ` Charles A. Roelli
2019-02-11 20:15                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr2bte0sj.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=32991@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).