From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#40661: Crash in regex search during redisplay Date: Fri, 17 Apr 2020 12:00:27 -0400 Message-ID: References: <83ftd3e92z.fsf@gnu.org> <83d087e6gj.fsf@gnu.org> <421071D0-6D75-4442-AC4B-D091B573B49C@dancol.org> <838siucq7b.fsf@gnu.org> <83tv1iaz7g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="64562"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rcopley@gmail.com, 40661@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 17 18:02:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPTRg-000GhR-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Apr 2020 18:02:25 +0200 Original-Received: from localhost ([::1]:49096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPTRf-0001A6-Uu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Apr 2020 12:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56943) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPTQN-0007bU-Rk for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 12:01:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPTQM-0007hu-Ov for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 12:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58229) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPTQM-0007hk-Lb for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 12:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPTQL-0001j9-KD for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2020 12:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2020 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40661 X-GNU-PR-Package: emacs Original-Received: via spool by 40661-submit@debbugs.gnu.org id=B40661.15871392376599 (code B ref 40661); Fri, 17 Apr 2020 16:01:01 +0000 Original-Received: (at 40661) by debbugs.gnu.org; 17 Apr 2020 16:00:37 +0000 Original-Received: from localhost ([127.0.0.1]:41542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPTPx-0001iN-If for submit@debbugs.gnu.org; Fri, 17 Apr 2020 12:00:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPTPv-0001i9-VW for 40661@debbugs.gnu.org; Fri, 17 Apr 2020 12:00:36 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6CC8810032F; Fri, 17 Apr 2020 12:00:30 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B00ED10024E; Fri, 17 Apr 2020 12:00:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1587139228; bh=gmePp3/Nu40PKutTuyAFLxCE9/8Dh47FxxCdVHfvQbQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Bf+USi3WuK9OGpQJh2b/ZT2MuUwrY9nNsM/zCavbjMYTcqTH9IwcU+0fBsRcdboBj JemcCb+/NYYkPCYL9H/pnG58hwdtAr6aPltTRDfJvuzmCDqnS+OUAKkA9IbCkrleJh 7X38hXpKjwuuNeBgPC5fEdL4MZe6KYZ4HSsu0MVC3q/7DCBlVnqT7jY1r7J0tbq0GD vKdXTzqF2mXK5T/TzWa5RL9mQIDKOC6ylH8HzWJRlq3fwyqLw5i+L6ajzmaTFXrGtk P5gt+gPPY0Qx6GWm2XIJpZt3oa7ep7BciShePG24kT9hnlmHWnKLGUhZHDN9jy9r0y NjpZ6peZK8Pug== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 53C36120871; Fri, 17 Apr 2020 12:00:28 -0400 (EDT) In-Reply-To: <83tv1iaz7g.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Apr 2020 18:50:27 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178528 Archived-At: >> > Obviously, we cannot allow GC to run while regex routines do their >> > work, because they are passed C pointers to buffer text. The question >> > is, where to disable GC? We could do it inside >> > update_syntax_table_forward, but UPDATE_SYNTAX_TABLE_FORWARD is called >> > from many places that evidently have no problems with GC. So my >> > suggestion would be to disable GC inside re_match_2_internal instead. >> > Comments? >> Looks fine to me. > So you prefer disabling GC to setting the inhibit_shrinking flag? > I tend to agree with Daniel here, FWIW. No, what I meant was that I'm fine with doing it "inside re_match_2_internal" instead of "inside update_syntax_table_forward". But I prefer if the "it" is setting `inhibit_shrinking` instead of inhibiting the GC altogether. > That's a project for another pandemic ;-) I want a simple enough > solution for now that we could install on the release branch. Oh, for `emacs-27` that's clearly out, indeed. But for `master` it should not be that hard. I think we can reuse `pending_funcalls` for that. Stefan