From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Fri, 23 Apr 2021 11:53:13 -0400 Message-ID: References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> <87r1jatd34.fsf@mail.linkov.net> <7dee3f423551aaf318cb@heytings.org> <87im4kzlfm.fsf@mail.linkov.net> <1869622e16546eafd9df@heytings.org> <871rb6np5j.fsf@mail.linkov.net> <87lf9cepqw.fsf@mail.linkov.net> <87k0oukn3n.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , Dario Gjorgjevski , 45474@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 23 17:54:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZy89-00015b-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 17:54:09 +0200 Original-Received: from localhost ([::1]:55550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZy88-0004EX-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Apr 2021 11:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZy82-0004EO-Dw for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 11:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZy82-0001Bg-6A for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 11:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZy82-0000is-50 for bug-gnu-emacs@gnu.org; Fri, 23 Apr 2021 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Apr 2021 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16191932032725 (code B ref 45474); Fri, 23 Apr 2021 15:54:02 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 23 Apr 2021 15:53:23 +0000 Original-Received: from localhost ([127.0.0.1]:38632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZy7P-0000ht-6h for submit@debbugs.gnu.org; Fri, 23 Apr 2021 11:53:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZy7N-0000hh-OH for 45474@debbugs.gnu.org; Fri, 23 Apr 2021 11:53:22 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 171D98088B; Fri, 23 Apr 2021 11:53:16 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A6AA2801AB; Fri, 23 Apr 2021 11:53:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619193194; bh=wBzgpRHwE6wHjq4wP6AnAZjf8tMqDrGnj/ur5zXh5C8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OQQ/bFSUf71yxp9Y5UzCAhEJoJj8563R4AWzMc8j1xkbKX58OwbNkSO/oEwjCupMK Gy6nEjoSvIKXdA0tPsjL/PmR52Fm/PZ0QDbEi1rcbtuoOCg9ZM48J+W8KmOGxWAaPK SQugSp6J+04xFm26odHXtKXSnBPRMNfey3l58MXJczfERdN/aHa0FENlOFBlORcFNw DC5QHLQ87fKgSiEV3MbadvgTqMbm7hXsI1aPmdjUc2udMZYlIzCcjum9GX6+CnOC3k tqda5fmyvPQO20Ql/HBIk/0QZU0cGy7nm1QyNTGyZDxNlhEpDwtGyrTRi1JOfUc5Ju XGj6gh4p8HEWQ== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7398E12038D; Fri, 23 Apr 2021 11:53:14 -0400 (EDT) In-Reply-To: <87k0oukn3n.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 23 Apr 2021 00:57:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204744 Archived-At: >> I'm more and more thinking that we should really bite the bullet and go >> for a "really buffer-local" setup, such as in the patch below. >> I'd be surprised if it doesn't introduce backward incompatibilities, but >> at least it's "The Right Thing" to do. > I've tested your new patch with tests that Gregory posted > in an earlier message that cover all cases of nested > completion and non-completion minibuffers: AFAICT my proposed patch should work fine with the builtin UI and with icomplete, yes. I expect ido-ubiquitous should also work just fine. The only significant source of incompatibility I can foresee is for code which uses `minibuffer-completion-*` from code running outside of the minibuffer (such as in a buffer like *Completion*). There's another source of incompatibility for functions that currently operate like `completion-read-default` (i.e. let-bind `minibuffer-completion-*` and then use that setting in another buffer, such as a new minibuffer): these may fail to work when used from within a completing minibuffer. Stefan