From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Thu, 06 May 2021 09:27:38 -0400 Message-ID: References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17744"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , 48137@debbugs.gnu.org To: Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 15:28:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lee3C-0004Wm-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 15:28:22 +0200 Original-Received: from localhost ([::1]:39020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lee3B-0002Ei-4G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 09:28:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lee2t-0002EV-Qf for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:28:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lee2s-0001Hw-BV for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lee2s-0000c6-7r for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 09:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 13:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.16203076682342 (code B ref 48137); Thu, 06 May 2021 13:28:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 6 May 2021 13:27:48 +0000 Original-Received: from localhost ([127.0.0.1]:37544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lee2e-0000bi-Bs for submit@debbugs.gnu.org; Thu, 06 May 2021 09:27:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lee2c-0000ba-Iu for 48137@debbugs.gnu.org; Thu, 06 May 2021 09:27:47 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 55FF4440943; Thu, 6 May 2021 09:27:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DBD954408C9; Thu, 6 May 2021 09:27:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620307658; bh=hah2WwDhJECCOeAaCjKm6WUk6DyQDj8Dy+7I1uxDxFI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VWMlBMTlLZLqU2bcU1eGQNDLNsmYDrb8JVNDRbsN7+VKF6+wRhmYouxnHhIJkb/hx hOYjJ2lZAYnYzWR/IGzb1Aw1vRv8wOnqffTHGEu7aNZFVv9NOAl7CAX3sy4CDEuQF0 T86WK/T7cgIQJv7QBolf3fBHIO8zomhTXva3kiRVuqbf480Ft9fpRVtZaHa3BjpmeI lTTzxikqF+ETSprazw0jnK8ruxP6djR4Ky2xSD5FL8PZY+Z2XcpxfGKET52aQ5qnzX GW9iImYTFai0SnBspQplB2zHANPZ88WNkMSV/RXOr5KSK3QaU6k0wUOTZr1psoWnjD 7nmKnHEcdTxcw== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE1FE120328; Thu, 6 May 2021 09:27:38 -0400 (EDT) In-Reply-To: (Ioannis Kappas's message of "Thu, 6 May 2021 07:55:52 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205832 Archived-At: >> My idea was to read the file literally, without decoding, then parse >> the package headers from that. > I suppose you mean something along the other option below? That's not sufficient, because if we don't decode the file before we call `package-buffer-info` (from `package-install-from-buffer`), then the -pkg.el file will have incorrect content (e.g. the non-ASCII chars in the description of the package, will be later incorrectly displayed in `list-packages`). Stefan