From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48572: 28.0.50; Add `passthrough` completion style to minibuffer.el Date: Sun, 23 May 2021 11:50:56 -0400 Message-ID: References: <2ebf9ed0-bd5d-8107-9d22-61e56f29c02a@daniel-mendler.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24696"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48572@debbugs.gnu.org, joaotavora@gmail.com To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 23 17:52:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkqOf-0006Gh-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 May 2021 17:52:09 +0200 Original-Received: from localhost ([::1]:39460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkqOe-0007LJ-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 May 2021 11:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkqOY-0007LA-17 for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 11:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkqOX-0003RM-QH for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 11:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkqOX-0004JD-OZ for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 11:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 May 2021 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48572 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, joaotavora@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.162178507216508 (code B ref -1); Sun, 23 May 2021 15:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 May 2021 15:51:12 +0000 Original-Received: from localhost ([127.0.0.1]:41676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkqNk-0004IB-8r for submit@debbugs.gnu.org; Sun, 23 May 2021 11:51:12 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkqNf-0004I1-9t for submit@debbugs.gnu.org; Sun, 23 May 2021 11:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkqNf-0007Ee-1Q for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 11:51:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54441) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkqNd-0002x1-Cw for bug-gnu-emacs@gnu.org; Sun, 23 May 2021 11:51:06 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F1D64808A3; Sun, 23 May 2021 11:51:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DD09A80169; Sun, 23 May 2021 11:50:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621785057; bh=ri4XXz4QOB1Iocm7GYPELnVGPKLdp/fmfqiKqSuFtL8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HWk3xRHZGEcBZ8DDLt80NZTgoL35XsskHLInWSMFtJrfGD42Se9xwJ+Mw6ZWez0uF 0iE8/YsF5sx8yN0GTt8H29e45HB7kiYTFVxJ+xk2R1tRX8CWqBAyKxkIH1icJMn5E8 A1O1v5cITuFsmfnuVNeCaXgAjsOIVq6R9H+2Y59grwh0Lv8/k0jqRqTaKKgV31rmlN eDq56zgLzOwOGCNZGStajhZiFRAzLTaZBIqbHW6RWbcOOR3y9cb7eHgWai2FeyHB4E MktxoNPYjfWzoo/HPaX5WolBrPHFIF8ptU58ca4wKg8PORxg3C5586HQGe1hkyG0Dt nSuoGbTTUrp3g== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 908FF12055F; Sun, 23 May 2021 11:50:57 -0400 (EDT) In-Reply-To: <2ebf9ed0-bd5d-8107-9d22-61e56f29c02a@daniel-mendler.de> (Daniel Mendler's message of "Sun, 23 May 2021 12:21:33 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207094 Archived-At: >> Clearly, this is not right: passthrough completion should pass the `str` >> and `point` info to the completion table. The completion table may opt >> to ignore that information, but we shouldn't prevent them from using it. >> I expect most passthrough uses will want to use `str`. > > I see what you mean. In my use case I didn't use an improperly > implemented completion table which does not ignore . However the > question is then if this "passthrough" style is really needed since if > you don't ignore the input, it is mostly equivalent to the emacs21 style. The "passthrough" (elsewhere called "backend") completion-style is definitely something we need to add, yes. But what it should do is pass all the args from `completion-all/try-completions` to the table and let the table do *all* the work, i.e. let the completion table implement the completion-style methods. But we shouldn't call `all-completions` or `try-completions` for that. Instead we should call the completion-table directly, as is done for the `completion-boundaries` method. Stefan