From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50898: 28.0.50; with-suppressed-warnings doesn't always work Date: Tue, 30 Nov 2021 08:50:10 -0500 Message-ID: References: <87r1d76wne.fsf@gnus.org> <871r56evhk.fsf@web.de> <87tuftojab.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Heerdegen , 50898@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 30 15:15:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms3ut-0006ZN-QQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 15:15:32 +0100 Original-Received: from localhost ([::1]:41800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ms3us-0006E6-La for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 09:15:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms3XE-0002Am-Ct for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:51:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ms3XC-0004Er-4X for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:51:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ms3XB-0004Kl-RM for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2021 13:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50898 X-GNU-PR-Package: emacs Original-Received: via spool by 50898-submit@debbugs.gnu.org id=B50898.163828022116596 (code B ref 50898); Tue, 30 Nov 2021 13:51:01 +0000 Original-Received: (at 50898) by debbugs.gnu.org; 30 Nov 2021 13:50:21 +0000 Original-Received: from localhost ([127.0.0.1]:40438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms3WX-0004Jc-7O for submit@debbugs.gnu.org; Tue, 30 Nov 2021 08:50:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms3WV-0004JM-0W for 50898@debbugs.gnu.org; Tue, 30 Nov 2021 08:50:19 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2E1368067C; Tue, 30 Nov 2021 08:50:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 93176804AB; Tue, 30 Nov 2021 08:50:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1638280211; bh=zoq80dcDesfsWPyuXzwIg/g2d05ChiArV8sqWoVcJRs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Og5kL07Zxh3NkIFpivii8aAAsldImfGwTZ2EhiT5N4B26Biw0Lffj2oPUTPDj61NI CYR+zzxbquWsTuzAAR8x6aC3JdWkVyFXehsuskgNhz9IoA6b5N33ZhpYKOz04Ivpua TBAnoB+n1McMVB+EVuLNFUcaDtRSgezalVhI0KfSuavD60BmtcJ8erNgrwulT1j+Q5 cVjwfxYBLF+PpV52sngRPuGcjeQzNQtfX2AZ5RH6M+P0/BIEv+OAoTYll05H1lLwIT jR0Or39OsogSBo3izDZUKbH8ainGxg4VaYpyX9rSOjhMLsBh2A1jis+vMfMlZD0E50 YqKxfKYPQoHeQ== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 581BC12068B; Tue, 30 Nov 2021 08:50:11 -0500 (EST) In-Reply-To: <87tuftojab.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 30 Nov 2021 14:38:36 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221122 Archived-At: > This should now work again on the trunk. Hmm... @@ -216,10 +216,11 @@ macroexp-macroexpand (let* ((fun (car form)) (obsolete (get fun 'byte-obsolete-info))) (macroexp-warn-and-return - (macroexp--obsolete-warning - fun obsolete - (if (symbolp (symbol-function fun)) - "alias" "macro")) + (and (byte-compile-warning-enabled-p 'obsolete fun) + (macroexp--obsolete-warning + fun obsolete + (if (symbolp (symbol-function fun)) + "alias" "macro"))) new-form 'obsolete)) new-form))) I suspect this can fail if `bytecomp.el` is not yet loaded. I think "the right way" to do that is to improve `macroexp-warn-and-return` so that instead of only receiving `obsolete` as `category` to decide if the warning is enabled or not, it should additionally also receive `fun`. Stefan