From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: 55684-done@debbugs.gnu.org
Subject: bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames
Date: Sat, 28 May 2022 10:22:24 -0400 [thread overview]
Message-ID: <jwvr14deo5f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <YpH+ALS9Ly//hYvl@ACM> (Alan Mackenzie's message of "Sat, 28 May 2022 10:48:32 +0000")
>> @@ -1576,8 +1576,14 @@ do_switch_frame (Lisp_Object frame, int track, int for_deletion, Lisp_Object nor
>> to a different window, the most recently used one, unless there is a
>> valid active minibuffer in the mini-window. */
>> if (EQ (f->selected_window, f->minibuffer_window)
>> + /* FIXME: Can this test ever fail? I.e. can 'minibuffer_window'
>> + ever contain a non-mini-buffer (and if so, should we care here)? */
>> && NILP (Fminibufferp (XWINDOW (f->minibuffer_window)->contents, Qt)))
>
> Yes, the test can fail. The buffer in the mini-window might be (the
> non-active) minibuffer 0. The meaning of the argument Qt is to return
> non-nil only for active minibuffers.
Ah, indeed I missed this detail. I guess that mini window can
also hold the echo area. Thanks for the explanation,
Stefan
prev parent reply other threads:[~2022-05-28 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 20:09 bug#55684: 29.0.50; wrong-type-argument in minibuffer-only frames Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-28 5:56 ` Eli Zaretskii
2022-05-28 10:51 ` Alan Mackenzie
2022-05-28 10:57 ` Eli Zaretskii
2022-05-28 13:09 ` Alan Mackenzie
2022-05-28 13:18 ` Eli Zaretskii
2022-05-28 10:48 ` Alan Mackenzie
2022-05-28 14:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr14deo5f.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=55684-done@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).