From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 19:10:16 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <83a5vxas9k.fsf@gnu.org> <877cr1nep6.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 01:11:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKoQ7-00071C-Sw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 01:11:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKoPp-0000AH-Hy; Sat, 15 Jul 2023 19:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKoPm-00009r-RO for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 19:11:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKoPm-0001g3-JH for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 19:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKoPm-0001Rq-4N for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 19:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16894626275524 (code B ref 64596); Sat, 15 Jul 2023 23:11:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 23:10:27 +0000 Original-Received: from localhost ([127.0.0.1]:46245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKoPD-0001R2-Cz for submit@debbugs.gnu.org; Sat, 15 Jul 2023 19:10:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKoP9-0001Qj-S2 for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 19:10:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 95FD28065C; Sat, 15 Jul 2023 19:10:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8F881805DE; Sat, 15 Jul 2023 19:10:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689462617; bh=U1dfbkM0UQfa/ILHec4hu/Bz3ioXQe6MPvnIFb51HMc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LRyv8hzWaVxh2srW7Oj9z8QTUhJB3wzp4OzsE2yu8waWMpbXekDhAnOjP467sTFt+ BOnZkAuCvPkyq+Uc7CNqj2BEtlGUNSeUqhtUcQbk1diNCCkGz6IKu8C88Iu9d1vhzQ PIDurAdt8KBpDQe6SR4TJXLaJd+rL9tIoNmGhj9LYzgQQOrPxenW2RYjzpMlgvlGfa CVOqdXHydcQYKa9YQ16anN475qRw9gn8P4qMLWgI3kp3FuQKltWfewc/6uqbij8Q5z ObecoQIgcRgYkl05X2XKEqgkswuoNeyqq5oMFXrD1E/4W5g7eOKOq4CT0jw2kl0FPB XpUxW77SaB3Xw== Original-Received: from pastel (unknown [104.247.238.169]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 65E2B120165; Sat, 15 Jul 2023 19:10:17 -0400 (EDT) In-Reply-To: <877cr1nep6.fsf@localhost> (Ihor Radchenko's message of "Sat, 15 Jul 2023 19:43:17 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265254 Archived-At: >> The actual issue with the above is different: it implies that >> update_mode_lines _always_ indicates that more than a single mode line >> should be updated (which is why we need to "consider all windows"). >> But is that actually true, i.e. does every place that assigns non-zero >> to update_mode_lines indeed perform a change which makes it >> _necessary_ to consider non-selected windows? > > At least, when the current buffer is only displayed in a single, > selected window, checking every window should not be necessary. Indeed, we have a special case for that. Before my change, it was either "just the selected window" or "all windows". > Compare bset_redisplay and bset_update_mode_line. Indeed the old code updated all windows after a call to `force-mode-line-update` even if the current buffer is only displayed in the selected window and I somewhat preserved that :-( Stefan