From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64681: 30.0.50; slow saving of scores when leaving an nnml group in gnus Date: Mon, 17 Jul 2023 09:10:25 -0400 Message-ID: References: <87ilai9276.fsf@ucl.ac.uk> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38705"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64681@debbugs.gnu.org To: "Fraga, Eric" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 15:11:42 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLO0r-0009tA-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 15:11:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLO0W-0005pz-Ue; Mon, 17 Jul 2023 09:11:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLO0E-0005mi-Ix for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:11:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLO0D-00071Q-RZ for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLO0D-0004v6-Mb for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64681 X-GNU-PR-Package: emacs Original-Received: via spool by 64681-submit@debbugs.gnu.org id=B64681.168959943818886 (code B ref 64681); Mon, 17 Jul 2023 13:11:01 +0000 Original-Received: (at 64681) by debbugs.gnu.org; 17 Jul 2023 13:10:38 +0000 Original-Received: from localhost ([127.0.0.1]:49405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLNzp-0004uX-Kg for submit@debbugs.gnu.org; Mon, 17 Jul 2023 09:10:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLNzm-0004uD-5z for 64681@debbugs.gnu.org; Mon, 17 Jul 2023 09:10:35 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8BC161000C3; Mon, 17 Jul 2023 09:10:28 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 896C3100089; Mon, 17 Jul 2023 09:10:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689599427; bh=D8Y5TyE6xThJG8cwYq58na2EANCwIyRiTReaOxjIfEU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NaYFvNYBKbW0eqvFn0LdHXoJed9E2jOdP7nIJ4QA+7C0Mu/A4t+yB5xB+wNN1NbiT IRfZEM7sHQB/bNoRJrzSdH3+UNAErdba4W7VtHn50qXXg6c/wvrE4RVpZX1PWDgvOf hUeshUYL1h/uQB9hJNZD2dw8Q3b7C66EWIXL4NJB+mP+34XHwzxfZZIoJALW3WdAL6 BQQG0uU2wKZp+boVvNDEHYrrJAx9p1wi9cMAg+5s2f/xEOjb5psEJop2RDeAmg++Q+ 1FNUaBvNi6SEdz3KePknooRskOYXbtzz3GvYU6EoqKw6pDhVW+mBDHXdJYc3zTAa+l SgIlHONssLSSg== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6786A12033B; Mon, 17 Jul 2023 09:10:27 -0400 (EDT) In-Reply-To: <87ilai9276.fsf@ucl.ac.uk> (Eric Fraga's message of "Mon, 17 Jul 2023 12:01:34 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265395 Archived-At: > A significant amount of time is taken saving scores, as far as I can > tell. I use adaptive scoring. Nothing with respect to scoring has > changed in my configuration in some time (years probably). If you could send me your biggest scoring file I could try and reproduce it locally. I understand it contains private information, so you might want to "sanitize" it first e.g. by doing a search&replace such as C-u M-% ".+" RET "xxxx" RET [ Maybe you'll need to tweak the regexp, e.g. if you have strings that contain the double quote character or that span more than one line. E.g. maybe search for \" before doing the above. If you need more help with that, let me know. ] > The offending function appears to be "lisp--local-defform-body-p" with > large memory and cpu use. Indeed. > After discussion on the gnus mailing list, the culprit would appear to > be the pretty-printing. Setting pp-default-function to 'pp-28 instead > of 'pp-fill restores the behaviour to what is desirable in terms of > speed. Yup, the underlying difference is that the new `pp-fill` uses `lisp-indent-line` whereas the old code (`pp-28`) uses `lisp-indent-region`. In most cases, the algorithmic complexity of calling `lisp-indent-line` on every line of a region should be the same as that of `lisp-indent-region`, but sometimes performance bugs creep in :-( Stefan