From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Wed, 13 Sep 2023 10:51:54 -0400 Message-ID: References: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8031"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61396@debbugs.gnu.org, Samuel Wales To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 13 16:54:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qgRFu-0001sQ-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Sep 2023 16:54:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgRFe-0005WR-BS; Wed, 13 Sep 2023 10:53:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgRFc-0005W6-OD for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:53:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgRFc-00012E-GO for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:53:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgRFh-0002DE-O8 for bug-gnu-emacs@gnu.org; Wed, 13 Sep 2023 10:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Sep 2023 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.16946167988453 (code B ref 61396); Wed, 13 Sep 2023 14:54:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 13 Sep 2023 14:53:18 +0000 Original-Received: from localhost ([127.0.0.1]:35619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgRF0-0002CH-4M for submit@debbugs.gnu.org; Wed, 13 Sep 2023 10:53:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgREy-0002C5-4v for 61396@debbugs.gnu.org; Wed, 13 Sep 2023 10:53:17 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0B3FA441BD8; Wed, 13 Sep 2023 10:53:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694616783; bh=jgalYovRBdKAPaR/Jh8Lu2LvxrnNrE0ZbQhD+4hrdhc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e9qdlDh1CJ8uGT2Carmr9JfYqyJwlmPQmIULvEjBXroHVgza0dO8f2Z1/MMkjR8Be qLb8oXCC0QbKhObi9XZkqTPjYbFvVHUtBf0xOV/U6eyhVmo1oA7+1SbsbLzCXA46q7 YLa416yjs1QWgbYv2hpxGeTwCEhrQWF/vFbWpxlXJ5CN0WggEoI6+SwPmt5YIvQwsz kS+DPLDU5Bso9zFtjDQyinYMBC13phLXCUsxydqfKomTWc5V+ZbceMTbeRZ1pk8aoz 1m7MMCGCiFkmp+mArSuSZZlXLmECAUXWLx2VvpfBdskG3y1J95808JWlyA/Us1jN5F WaWEbivucR7UQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 82BF9441BD5; Wed, 13 Sep 2023 10:53:03 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 74AA9120401; Wed, 13 Sep 2023 10:53:03 -0400 (EDT) In-Reply-To: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> (Dmitry Gutov's message of "Wed, 13 Sep 2023 01:31:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270306 Archived-At: > Not quite ready indeed: the new option is unused (implied to be t, I guess). Oops :-) This said, it's not its only problem: the name of that var sucks as well. > Just a single piece of feedback: I get where the idea is coming from (and > it's good in theory), but I'm not loving the added bright spots of color > where there previously were just toned down lighter backgrounds. Yeah, I'm unsure about that. I'm also somewhat annoyed by the extra attention it brings to those "boring" additions and removals, but I'm wondering if it's really because I want them to look more dull or if it's just because of habit. I have been bitten several times in the past when going through largish diffs where I overlooked important things in the added/removed parts because they were colored the same was as the unchanged parts of changed lines and so I just glossed over them. > If it were indicated differently somehow (though I'm not sure how), perhaps > I'd like it more. As it is, though, the added value (quite minor since it's > easy to see which hunk is "pure addition" already) doesn't seem to balance > out the inconvenience. Yeah, maybe I'd prefer colors that are halfway between `diff-added/removed` and `diff-refine-added/removed`? [ Wish we had dynamically-computed face colors for that. ] Stefan