From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 9438@debbugs.gnu.org
Subject: bug#9438: grep regressions
Date: Tue, 06 Sep 2011 21:22:30 -0400 [thread overview]
Message-ID: <jwvpqjdtanb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87vct8gmjj.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 05 Sep 2011 11:34:04 +0300")
> Unfortunately, I can't find a simpler way to fix it than this patch:
It doesn't look too terrible.
> + ;; Calculate column positions (col . end-col) of first grep match on a line
> + ((lambda ()
> + (when grep-highlight-matches
> + (setq compilation-error-screen-columns nil)
Why set it here? I know it used to be set similarly, but I think it
should be set once and for all in grep-mode instead.
> + (save-excursion
> + (let* ((beg (progn (goto-char (match-end 0)) (point)))
Why not
(save-excursion
(goto-char (match-end 0))
(let* ((beg (point))
Or better yet:
(let* ((beg (match-end 0))
(end (save-excursion (goto-char beg) (line-end-position)))
-- Stefan
next prev parent reply other threads:[~2011-09-07 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 8:34 bug#9438: grep regressions Juri Linkov
2011-09-07 1:22 ` Stefan Monnier [this message]
2011-09-07 12:09 ` Juri Linkov
2011-09-08 20:18 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpqjdtanb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9438@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).