From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12894: 24.2.50; Auto refine all hunks in a diff Date: Thu, 15 Nov 2012 09:44:19 -0500 Message-ID: References: <804nkrp061.fsf@somewhere.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352990733 16464 80.91.229.3 (15 Nov 2012 14:45:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2012 14:45:33 +0000 (UTC) Cc: 12894-done@debbugs.gnu.org To: "Fabrice Niessen" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 15:45:44 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZ0hH-0006q9-VD for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 15:45:40 +0100 Original-Received: from localhost ([::1]:40754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0h8-000182-82 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 09:45:30 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0h3-00016x-8H for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 09:45:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ0h0-000630-6A for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 09:45:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ0h0-00062p-1A for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 09:45:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZ0hf-0007Vx-22 for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 09:46:03 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2012 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12894 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Mail-Followup-To: 12894@debbugs.gnu.org, monnier@iro.umontreal.ca, fni@missioncriticalit.com Original-Received: via spool by 12894-done@debbugs.gnu.org id=D12894.135299070428803 (code D ref 12894); Thu, 15 Nov 2012 14:46:02 +0000 Original-Received: (at 12894-done) by debbugs.gnu.org; 15 Nov 2012 14:45:04 +0000 Original-Received: from localhost ([127.0.0.1]:44621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ0gi-0007UV-2k for submit@debbugs.gnu.org; Thu, 15 Nov 2012 09:45:04 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:40401) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ0gg-0007U7-Em; Thu, 15 Nov 2012 09:45:02 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09sr+ZY/2dsb2JhbABEsEiDSYEIghYBBVYjEAsOJhIUGA0kiCG6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="207678288" Original-Received: from 108-175-230-88.dsl.teksavvy.com (HELO pastel.home) ([108.175.230.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Nov 2012 09:44:20 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D6E58594C8; Thu, 15 Nov 2012 09:44:19 -0500 (EST) In-Reply-To: <804nkrp061.fsf@somewhere.org> (Fabrice Niessen's message of "Thu, 15 Nov 2012 12:37:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 0.8 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66958 Archived-At: tags 12894 notabug thanks > ;; enable Diff Auto Refine mode (highlight the changes with better > ;; granularity) > (defun my/diff-refine-all-hunks () > (interactive) > (condition-case nil > (save-excursion > (goto-char (point-min)) > (while (not (eobp)) > (diff-hunk-next))) > (error nil))) The fact that my/diff-refine-all-hunks does not call diff-refine-hunk is a good indication that your code is at least brittle, since it relies on some side-effect of diff-hunk-next. What you're seeing is that diff-hunk-next's use of diff-refine-hunk is only meant for interactive use, so all it does is schedule diff-refine-hunk to be run "at the end of the current command". Stefan