unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview)
@ 2014-07-10  7:05 Dani Moncayo
  2014-07-19  1:44 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Dani Moncayo @ 2014-07-10  7:05 UTC (permalink / raw)
  To: 17984

emacs -Q
Select a couple of lines.
C-x r t

At that moment, I see this error in the echo area:
  Error in post-command-hook (rectangle--string-preview):
(wrong-type-argument stringp nil)

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-07-09 on LEG570
Repository revision: 117503 sds@gnu.org-20140709145152-p0uy20pnxfum36cs
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'

-- 
Dani Moncayo





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview)
  2014-07-10  7:05 bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview) Dani Moncayo
@ 2014-07-19  1:44 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-07-19  1:44 UTC (permalink / raw)
  To: Dani Moncayo; +Cc: 17984-done

> emacs -Q
> Select a couple of lines.
> C-x r t
> At that moment, I see this error in the echo area:
>   Error in post-command-hook (rectangle--string-preview):
> (wrong-type-argument stringp nil)

Indeed, thanks.  I installed the patch below which should fix this
problem,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2014-07-16 17:06:12 +0000
+++ lisp/ChangeLog	2014-07-19 01:43:04 +0000
@@ -1,3 +1,8 @@
+2014-07-19  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+	* rect.el (rectangle--string-preview): Don't assume there
+	a non-nil default (bug#17984).
+
 2014-07-16  Glenn Morris  <rgm@gnu.org>
 
 	* desktop.el (after-init-hook): Disable startup frame restoration

=== modified file 'lisp/rect.el'
--- lisp/rect.el	2014-07-09 02:20:21 +0000
+++ lisp/rect.el	2014-07-19 01:41:57 +0000
@@ -396,7 +396,7 @@
     (when (equal str "")
       (setq str (or (car-safe minibuffer-default)
                     (if (stringp minibuffer-default) minibuffer-default))))
-    (setq str (propertize str 'face 'region))
+    (when str (setq str (propertize str 'face 'region)))
     (with-selected-window rectangle--string-preview-window
       (unless (or (null rectangle--string-preview-state)
                   (equal str (car rectangle--string-preview-state)))






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-19  1:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-10  7:05 bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview) Dani Moncayo
2014-07-19  1:44 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).