From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18729: [PATCH] subr.el (set-key): New macro making creating new bindings more concise. Date: Thu, 16 Oct 2014 10:50:45 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1413471093 23437 80.91.229.3 (16 Oct 2014 14:51:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2014 14:51:33 +0000 (UTC) Cc: 18729@debbugs.gnu.org To: Michal Nazarewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 16 16:51:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XemOh-0002HG-S7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Oct 2014 16:51:23 +0200 Original-Received: from localhost ([::1]:50753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XemOh-0003mg-DR for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Oct 2014 10:51:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XemOX-0003ma-Lx for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2014 10:51:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XemOM-0005SM-Lp for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2014 10:51:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XemOM-0005SI-Iq for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2014 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XemOM-0000ML-1j for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2014 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Oct 2014 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18729-submit@debbugs.gnu.org id=B18729.14134710511363 (code B ref 18729); Thu, 16 Oct 2014 14:51:01 +0000 Original-Received: (at 18729) by debbugs.gnu.org; 16 Oct 2014 14:50:51 +0000 Original-Received: from localhost ([127.0.0.1]:46063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XemOA-0000Ls-Lz for submit@debbugs.gnu.org; Thu, 16 Oct 2014 10:50:51 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36101) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XemO7-0000Li-6f for 18729@debbugs.gnu.org; Thu, 16 Oct 2014 10:50:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEVhYKAxALDiYSFBgNJIgM0hkXjnoHhDgEqRmBaoFxgVsh X-IPAS-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIImAQEEVhYKAxALDiYSFBgNJIgM0hkXjnoHhDgEqRmBaoFxgVsh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="94352371" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Oct 2014 10:50:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 54ADA85A2; Thu, 16 Oct 2014 10:50:45 -0400 (EDT) In-Reply-To: (Michal Nazarewicz's message of "Thu, 16 Oct 2014 14:39:08 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:94620 > (I would still argue :args syntax is also convenient though). The :args syntax has the problem that it can only be explained/defined by explaining how args work for functions and how `interactive' works, so from a conceptual point of view (say, explaining to someone who doesn't know Elisp yet) it's not really simpler than the full (lambda ...) form. IOW the only gain is a few characters. >> (define-key MAP KEY '(dired "foo")) [...] > Thing I'm worried about here is that the function will not get > byte-compiled, whereas with set-key macro it will. Also, I'm not > entirely sure whether the function should use lexical-binding. Indeed, that's incompatible with lexical-binding. As you know, I find this to be a *major* downer. But the only alternative would be to define a new macro (like you've done), which implies a larger change, and added complexity: since we're not going to deprecate define-key, it means we'd simply have yet another slightly different way to define key bindings. I already dislike global-set-key and local-set-key, FWIW. I think if we want to make it easier for users to customize key-bindings, we should take a step back and look at the larger picture, trying to see exactly what it is that's hard. Maybe then we'll get a need for something that's substantially different from define-key (and in which your ideas can then easily be integrated). I'm thinking of things like tweaking key-bindings via Customize, and/or being able to specify keybindings for specific major modes (without needing to go through add-hook or eval-after-load), ... Stefan