From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18897: [PATCH] using advice-add Date: Thu, 30 Oct 2014 00:04:10 -0400 Message-ID: References: <8738a6v4hs.fsf@ericabrahamsen.net> <87a94effwp.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414641930 19775 80.91.229.3 (30 Oct 2014 04:05:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 30 Oct 2014 04:05:30 +0000 (UTC) Cc: 18897@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 30 05:05:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XjgzD-0003U0-VX for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Oct 2014 05:05:24 +0100 Original-Received: from localhost ([::1]:50738 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjgzD-0000OW-J9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Oct 2014 00:05:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjgz3-0000Nz-G7 for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 00:05:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xjgys-0006R6-GW for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 00:05:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xjgys-0006Qm-EG for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 00:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xjgyr-00039s-Pd for bug-gnu-emacs@gnu.org; Thu, 30 Oct 2014 00:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Oct 2014 04:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18897-submit@debbugs.gnu.org id=B18897.141464186012076 (code B ref 18897); Thu, 30 Oct 2014 04:05:01 +0000 Original-Received: (at 18897) by debbugs.gnu.org; 30 Oct 2014 04:04:20 +0000 Original-Received: from localhost ([127.0.0.1]:39633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XjgyC-00038h-4u for submit@debbugs.gnu.org; Thu, 30 Oct 2014 00:04:20 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:1062) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xjgy9-00038U-EH for 18897@debbugs.gnu.org; Thu, 30 Oct 2014 00:04:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au4MAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBAwFWIwULCzQSFBgNJIhLCctyAQEBAQYBAQEBHpEIB4RLBZ8Sg0mPRYFvhBQhgnoBAQE X-IPAS-Result: Au4MAOatTlRFpY87/2dsb2JhbABcgw6DYoZ+y1MEAgKBHBcBAXyEAwEBAwFWIwULCzQSFBgNJIhLCctyAQEBAQYBAQEBHpEIB4RLBZ8Sg0mPRYFvhBQhgnoBAQE X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="95562132" Original-Received: from 69-165-143-59.dsl.teksavvy.com (HELO pastel.home) ([69.165.143.59]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Oct 2014 00:04:11 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B14507CFF; Thu, 30 Oct 2014 00:04:10 -0400 (EDT) In-Reply-To: <87a94effwp.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Wed, 29 Oct 2014 19:30:14 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95286 > Here's a patch that replaces the defalias with an advice-add. Looks good, please install. See comments below. > * lisp/emacs-lisp/eieio.el (eieio-edebug-prin1-to-string): Modify > function for use as advice. Commit messages describe modifications, so "Modify" is a redundant verb. I'd say "Adjust for use as advice". > (edebug-setup-hook): Add `eieio-edebug-prin1-to-string' as advice on > `edebug-prin1-to-string'. I'd just say "Advise edebug-prin1-to-string". > + (advice-add #'edebug-prin1-to-string > + :around #'eieio-edebug-prin1-to-string))) This will work, but is conceptually wrong. It should be: (advice-add 'edebug-prin1-to-string :around #'eieio-edebug-prin1-to-string))) The thing that is modified by `advice-add' is the `symbol-function' field of the `edebug-prin1-to-string' symbol, so the first argument of advice-add should be a symbol, not a function. Stefan