* bug#19572: 24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries
@ 2015-01-12 10:36 João Távora
[not found] ` <handler.19572.B.142105898928305.ack@debbugs.gnu.org>
0 siblings, 1 reply; 5+ messages in thread
From: João Távora @ 2015-01-12 10:36 UTC (permalink / raw)
To: 19572
emacs -Q
M-x ielm RET
'foo RET
'bar RET
'(baz M-j bin) RET
M-x comint-history-isearch-backward RET b a z
expected the multi-line entry to be restored to input, but
comint.el fails to find it.
This is because `comint-history-isearch-search' uses
(goto-char (comint-line-beginning-position))
I think it should use `comint-goto-process-mark'. comint.el is a big
beast but I think this makes sense. Should I fix it thusly? (unless
anyone beats me to it)
João
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries)
[not found] ` <handler.19572.B.142105898928305.ack@debbugs.gnu.org>
@ 2015-01-12 10:42 ` João Távora
2015-01-12 15:15 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: João Távora @ 2015-01-12 10:42 UTC (permalink / raw)
To: 19572
Hi,
In the meantime, I found that
https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
offers a fix to exactly this problem, but I didn't find in the emacs-24 branch.
Shouldn't it go to emacs-24 as well?
João
On Mon, Jan 12, 2015 at 10:37 AM, GNU bug Tracking System
<help-debbugs@gnu.org> wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> bug-gnu-emacs@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 19572@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
> --
> 19572: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19572
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
--
João Távora
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries)
2015-01-12 10:42 ` bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) João Távora
@ 2015-01-12 15:15 ` Stefan Monnier
2015-01-12 21:02 ` Juri Linkov
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-01-12 15:15 UTC (permalink / raw)
To: João Távora; +Cc: 19572
> In the meantime, I found that
>
> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>
> offers a fix to exactly this problem, but I didn't find in the
> emacs-24 branch.
>
> Shouldn't it go to emacs-24 as well?
Hmm... I guess you're right, it probably belongs in emacs-24.
Can you backport it?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries)
2015-01-12 15:15 ` Stefan Monnier
@ 2015-01-12 21:02 ` Juri Linkov
2015-01-13 7:54 ` João Távora
0 siblings, 1 reply; 5+ messages in thread
From: Juri Linkov @ 2015-01-12 21:02 UTC (permalink / raw)
To: Stefan Monnier; +Cc: João Távora, 19572
>> In the meantime, I found that
>>
>> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>>
>> offers a fix to exactly this problem, but I didn't find in the
>> emacs-24 branch.
>>
>> Shouldn't it go to emacs-24 as well?
>
> Hmm... I guess you're right, it probably belongs in emacs-24.
> Can you backport it?
Sorry, I didn't realize that support for multi-line input should go
to emacs-24. The commits that need to be backported are:
f6c3965074dbf5f355ecce739104fb89fb4d90f8
a0ae3d7331f6126941f90c6b80c293685004e165
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries)
2015-01-12 21:02 ` Juri Linkov
@ 2015-01-13 7:54 ` João Távora
0 siblings, 0 replies; 5+ messages in thread
From: João Távora @ 2015-01-13 7:54 UTC (permalink / raw)
To: Juri Linkov, 19572-done; +Cc: 19572
Done. Two commits, one ChangeLog entry, informal backport references
copied from what others do. Looked ok.
On Mon, Jan 12, 2015 at 9:02 PM, Juri Linkov <juri@linkov.net> wrote:
>>> In the meantime, I found that
>>>
>>> https://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00299.html
>>>
>>> offers a fix to exactly this problem, but I didn't find in the
>>> emacs-24 branch.
>>>
>>> Shouldn't it go to emacs-24 as well?
>>
>> Hmm... I guess you're right, it probably belongs in emacs-24.
>> Can you backport it?
>
> Sorry, I didn't realize that support for multi-line input should go
> to emacs-24. The commits that need to be backported are:
>
> f6c3965074dbf5f355ecce739104fb89fb4d90f8
> a0ae3d7331f6126941f90c6b80c293685004e165
--
João Távora
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-13 7:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 10:36 bug#19572: 24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries João Távora
[not found] ` <handler.19572.B.142105898928305.ack@debbugs.gnu.org>
2015-01-12 10:42 ` bug#19572: Acknowledgement (24.4; M-x comint-history-isearch-backward doesn't search multi-line history entries) João Távora
2015-01-12 15:15 ` Stefan Monnier
2015-01-12 21:02 ` Juri Linkov
2015-01-13 7:54 ` João Távora
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).