From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20096: 25.0.50; Add Font-Lock support for subr-x macros Date: Thu, 12 Mar 2015 10:52:51 -0400 Message-ID: References: <87d24etxni.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426172009 12837 80.91.229.3 (12 Mar 2015 14:53:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Mar 2015 14:53:29 +0000 (UTC) Cc: 20096@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 12 15:53:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YW4U9-0007E0-HQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Mar 2015 15:53:17 +0100 Original-Received: from localhost ([::1]:60480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW4U8-0000WA-JO for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Mar 2015 10:53:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW4Tz-0000V3-32 for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 10:53:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW4Tu-0001oS-PH for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 10:53:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW4Tu-0001oC-MU for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 10:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YW4Tu-0008U7-7h for bug-gnu-emacs@gnu.org; Thu, 12 Mar 2015 10:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Mar 2015 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20096-submit@debbugs.gnu.org id=B20096.142617198032604 (code B ref 20096); Thu, 12 Mar 2015 14:53:02 +0000 Original-Received: (at 20096) by debbugs.gnu.org; 12 Mar 2015 14:53:00 +0000 Original-Received: from localhost ([127.0.0.1]:44072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YW4Ts-0008Tm-1S for submit@debbugs.gnu.org; Thu, 12 Mar 2015 10:53:00 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19949) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YW4Tp-0008TY-Aq for 20096@debbugs.gnu.org; Thu, 12 Mar 2015 10:52:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar8TAPOG1lRFpZs2/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLDiYSFBgNJIg4CM4jAQEBAQEBBAEBAQEej3gHhCoFmV+LG4R4gUUihAoignMBAQE X-IPAS-Result: Ar8TAPOG1lRFpZs2/2dsb2JhbABbgwaDX4VTvhyCSQQCAoENRAEBAQEBAXyEDQEEAVYjBQsLDiYSFBgNJIg4CM4jAQEBAQEBBAEBAQEej3gHhCoFmV+LG4R4gUUihAoignMBAQE X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="113376469" Original-Received: from 69-165-155-54.dsl.teksavvy.com (HELO pastel.home) ([69.165.155.54]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Mar 2015 10:52:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 15DC12092; Thu, 12 Mar 2015 10:52:51 -0400 (EDT) In-Reply-To: <87d24etxni.fsf@gnu.org> (Tassilo Horn's message of "Thu, 12 Mar 2015 09:42:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100408 Archived-At: > Is committing the following change the right thing to do? On that philosophical question, I think the answer would be: not quite. Instead, The Right Thing to do, might be to change elisp-mode's font-lock rules so they check obarray for macros (i.e. use mapatoms + regexp-opt to generate a macro matching all macros, and probably update it from after-load-functions)? That should kill several birds with a single (big) stone. Stefan "damn I hate those birds!"