unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 33937@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: bug#33937: 26.1; mhtml-mode fails to capture font-lock-keywords-case-fold-search
Date: Wed, 30 Oct 2019 17:19:00 -0400	[thread overview]
Message-ID: <jwvpniehr2o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mudiowzv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Oct 2019 20:26:44 +0100")

>        ;; Case fold during regexp fontification?
> -      (when (nth 2 defaults)
> -	(set (make-local-variable 'font-lock-keywords-case-fold-search) t))
> +      (if (nth 2 defaults)
> +          (set (make-local-variable 'font-lock-keywords-case-fold-search) t)
> +        (kill-local-variable 'font-lock-keywords-case-fold-search))
>
> It's slightly puzzling -- font-lock-keywords-case-fold-search is
> permanently buffer-local, but I guess that puzzlement was there before
> this patch, but the kill-local-variable thing is what makes mhtlm not
> work.
>
> Stefan, do you remember the reason for this change?

I can't remember the specific case, but I remember that it was basically
the inverse situation where font-lock-keywords-case-fold-search was left
at `t` instead of resetting it to the default nil.

I guess we should just

    (setq-local font-lock-keywords-case-fold-search (nth 2 defaults))

instead,


        Stefan






  reply	other threads:[~2019-10-30 21:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-31 15:13 bug#33937: 26.1; mhtml-mode fails to capture font-lock-keywords-case-fold-search Leo Liu
2019-10-30 19:26 ` Lars Ingebrigtsen
2019-10-30 21:19   ` Stefan Monnier [this message]
2019-10-31 13:08     ` Lars Ingebrigtsen
2019-10-31 20:30       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpniehr2o.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=33937@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).