From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>, 44592@debbugs.gnu.org
Subject: bug#44592: In sh-script-mode, should the syntax of . and / be made symbol?
Date: Wed, 23 Dec 2020 22:59:14 -0500 [thread overview]
Message-ID: <jwvpn2zsvw2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pn30kvo7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 23 Dec 2020 23:24:40 +0100")
>> The simplest solution I can think of is to change the
>>
>> (skip-syntax-backward "w_'")
>>
>> in ‘sh-smie--default-backward-token’ to
>>
>> (skip-syntax-backward ".w_'").
>>
>> This fixes the issue, but I’m not sure about unwanted effects.
>> Any ideas if it could cause something to misbehave?
>
> Perhaps Stefan has some comments here; added to the CCs.
I can't remember enough of how the syntax tables of sh-mode are setup.
So I suggest you just try it and see how it fares.
W.r.t only tweaking the SMIE behavior vs affecting `kill-sexp`, I think we
have `kill-word` for smaller chunks, so I don't see a convincing need to
use `kill-sexp` to stop at `/` boundaries.
But please add regression tests when you do that (and when you find
that it introduces new problems, please add those cases as additional
tests).
Stefan
next prev parent reply other threads:[~2020-12-24 3:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:49 bug#44592: In sh-script-mode, should the syntax of . and / be made symbol? Dario Gjorgjevski
2020-11-14 16:44 ` Lars Ingebrigtsen
2020-12-23 16:05 ` Dario Gjorgjevski
2020-12-23 22:24 ` Lars Ingebrigtsen
2020-12-24 3:59 ` Stefan Monnier [this message]
2021-08-27 17:09 ` Lars Ingebrigtsen
2021-08-28 9:44 ` Kévin Le Gouguec
2021-08-29 18:29 ` Lars Ingebrigtsen
2021-08-29 21:22 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvpn2zsvw2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=44592@debbugs.gnu.org \
--cc=dario.gjorgjevski@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).