From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49963: 28.0.50; isearch failing in Dired after rectangle-mark-mode and query-replace Date: Tue, 10 Aug 2021 10:30:54 -0400 Message-ID: References: <87k0kudsb8.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49963@debbugs.gnu.org, laslydone To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 16:32:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDSne-0007Bb-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 16:32:14 +0200 Original-Received: from localhost ([::1]:42870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDSnc-0003Jc-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 10:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDSnS-0003J9-JX for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 10:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDSnS-00016w-B8 for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 10:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDSnR-0002D2-Uc for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 10:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49963 X-GNU-PR-Package: emacs Original-Received: via spool by 49963-submit@debbugs.gnu.org id=B49963.16286058648427 (code B ref 49963); Tue, 10 Aug 2021 14:32:01 +0000 Original-Received: (at 49963) by debbugs.gnu.org; 10 Aug 2021 14:31:04 +0000 Original-Received: from localhost ([127.0.0.1]:60229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSmV-0002Br-TI for submit@debbugs.gnu.org; Tue, 10 Aug 2021 10:31:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDSmU-0002BO-ON for 49963@debbugs.gnu.org; Tue, 10 Aug 2021 10:31:03 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 50E314412B7; Tue, 10 Aug 2021 10:30:57 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C759440C5A; Tue, 10 Aug 2021 10:30:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1628605856; bh=3QYlkCNjx0nvWAlt61ihb7MsZtFhwAyWeuYSWUZCNPc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=L7c6z74IwfBCvo1CHueL2GHH4WM1sllHArtBpKj+rxPOgNL3J06pFd4WpHFJnAxja 95zWos5TnP7GS7JEcOOxMLqZA7SDzVMiGWq/gPrImC1WSG6Q4WwNPb2TDpVPAj/s7F eiFTP+vKe05uqmtlwsB0eKEuvY2YIy+/vpbjXJLPAf8JZGb+MoN2XG5GVuFVFTG/9U KyC1alNvIEMTO4wsMwf0IuclHYMP4cHzzgd5CgitjbIoAN70Af3C7xH7D9+qfS2ln9 jZUFzYcY7KVMqLR0JrdrPgwu80rlLr5ixD96pOnxEEeUfQXk68lg1AKfnLqKfc/7XV lvN9SEzRBPxuw== Original-Received: from alfajor (104-222-120-40.cpe.teksavvy.com [104.222.120.40]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DBD7F12039B; Tue, 10 Aug 2021 10:30:55 -0400 (EDT) In-Reply-To: <87k0kudsb8.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 10 Aug 2021 10:03:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211502 Archived-At: > (add-function :after-while (local 'isearch-filter-predicate) > (lambda (&rest _) 'filter-local)) > > (let ((isearch-filter-predicate isearch-filter-predicate)) > (add-function :after-while isearch-filter-predicate > (lambda (&rest _) 'filter-letbound))) > > C-h v isearch-filter-predicate: > > Value: > #f(advice-wrapper :after-while #f(compiled-function > (&rest args) > #) > (closure > (t) > (&rest _) > 'filter-local)) > Local in buffer *scratch*; global value is > #f(advice-wrapper :after-while isearch-filter-visible > (closure > (t) > (&rest _) > 'filter-letbound)) > > Let-binding was supposed to protect from changing the global value, But it doesn't, does it? So don't use `let`. Instead use `remove-function` with `unwind-protect`. Stefan