From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50268: 28.0.50; Assertion warning during native compilation Date: Tue, 21 Sep 2021 15:32:32 -0400 Message-ID: References: <87mto529jd.fsf@gnus.org> <9CF7F0E1-3C92-4F79-B3F3-E51E0E2D43C3@acm.org> <85h7edn9dn.fsf@gmail.com> <83bl4lyfv8.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12264"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mattiase@acm.org, larsi@gnus.org, Noam Postavsky , 50268@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 21 21:34:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSlWu-0002zF-0N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 21:34:12 +0200 Original-Received: from localhost ([::1]:48748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSlWs-0003Uu-JG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Sep 2021 15:34:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSlWk-0003Ul-JA for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 15:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSlWk-0001pf-An for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSlWk-0004nZ-8R for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Sep 2021 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50268 X-GNU-PR-Package: emacs Original-Received: via spool by 50268-submit@debbugs.gnu.org id=B50268.163225279718381 (code B ref 50268); Tue, 21 Sep 2021 19:34:02 +0000 Original-Received: (at 50268) by debbugs.gnu.org; 21 Sep 2021 19:33:17 +0000 Original-Received: from localhost ([127.0.0.1]:48064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSlW0-0004mP-TH for submit@debbugs.gnu.org; Tue, 21 Sep 2021 15:33:17 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSlVy-0004m7-En for 50268@debbugs.gnu.org; Tue, 21 Sep 2021 15:33:14 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7711C44132A; Tue, 21 Sep 2021 15:33:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9EF28441326; Tue, 21 Sep 2021 15:33:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1632252782; bh=vxHvQA5kPqvIFhNrwKIm9UeUlkwof49EYTSk7M8UjDg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=N7KwvChayAp8Bhtl/aaMeIAwjXcH3+WFcg1zyU7PiI+BBOgk8P6EH6CE3UwJityiD dZGYB/CGD9H2R2/pVRljah9OWnBBtnVWnRoZI3LM3CaCdjyDGTgkMjeqYEX1wFvChl MIPXcPFffl1Mmhyx3T8X1IDYrTD/8V3L1qKVxxajwGRw9s3ue3J5VsrdwwdWAvr5HI sfk9ZHPwSM0RTyKYqwaAixu/rssJN712OFdQa9HnL0THxtxY/KOu0DHnOx13Fhhoiz n9SdvtbQXvX06UTJ+8ulJcCA8soEEV7UtNVRmMqlhTGQo3Na9u8qdfJC2Xc5EFK8T5 EriqVbyy/mtNQ== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 912FD1201C8; Tue, 21 Sep 2021 15:33:02 -0400 (EDT) In-Reply-To: <83bl4lyfv8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Sep 2021 20:53:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215033 Archived-At: >> It's been a while, but looking at Bug#29165, the reason I added it is >> that it was supported in Emacs 25 and earlier. Stefan M had some >> justifications there for &optional without variables, but I think they >> don't apply for &rest. > Stefan, can you please chime in? With my type-systems-guy hat on, I'd say we want to detect those `&rest` without a following variable and shame the author of the code. But at the same time we could think of `&rest` as something similar to `&optional` and decide that it can be handy for generated code to be able to generate (x y &optional z &rest). The main difference I see is that `(x y &optional ,@args) makes a lot of sense and will naturally occasionally lead to `&optional` not followed by anything, whereas `&rest` only expects 1 following identifier so it seems much less likely that the code will sometimes put 0 vars in there. After all, we do signal an error if there's more than 1 var after `&rest`, so I think it makes sense to follow my types-systems-guy heart here. Stefan