From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58808: map-y-or-n-p should use read-key, not read-event Date: Thu, 27 Oct 2022 11:39:10 -0400 Message-ID: References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> <83fsf9n6xu.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14309"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58808@debbugs.gnu.org, meedstrom@teknik.io To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 17:41:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo50s-0003Tg-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 17:41:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo4zK-0007X6-Mq; Thu, 27 Oct 2022 11:40:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo4zD-0006vE-0b for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 11:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo4zC-0008RN-Gi for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 11:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oo4zB-0006p1-O3 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 11:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 15:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58808 X-GNU-PR-Package: emacs Original-Received: via spool by 58808-submit@debbugs.gnu.org id=B58808.166688516726179 (code B ref 58808); Thu, 27 Oct 2022 15:40:01 +0000 Original-Received: (at 58808) by debbugs.gnu.org; 27 Oct 2022 15:39:27 +0000 Original-Received: from localhost ([127.0.0.1]:59010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo4yZ-0006o8-UT for submit@debbugs.gnu.org; Thu, 27 Oct 2022 11:39:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo4yV-0006ns-J2 for 58808@debbugs.gnu.org; Thu, 27 Oct 2022 11:39:22 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CDD6880355; Thu, 27 Oct 2022 11:39:13 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 295D58035A; Thu, 27 Oct 2022 11:39:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666885152; bh=FKvuuWYiRTGwn6EiiCadId16nKSgmZx5vibdexiafOw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PRbz6cZI7B9jioMutDUlqa4XGBj97E2YkD5PzLFuyPrIxhtKGo8jN4rZNvQRePhaE 880MgXIwaxpjHEclh/LOzqZAHtMGlU2E8j8AApKBVJ8TpbBsMKhD+lw3FqdWwmA4bY QAvAeNUk46Rk6lZTiFhJq13bP7pfb00t4PirZUG7kDHjzB8owG/mTmx2Q3qQIRgoMd 3uU308BeO4AGkY6nh7lPImGUzBLiCgEZ8/3EeNimVKNPvjvEPuGdJnojHGf6SGOqcn h4CVpoL5tAFi66EJS8plwUu7NZwU9i8eMsJQUL+iBvPh+cEsWRTKYKGDEbfynlyCLm AkFmxCC+59/+Q== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BED441203D7; Thu, 27 Oct 2022 11:39:11 -0400 (EDT) In-Reply-To: <83fsf9n6xu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Oct 2022 08:58:53 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246310 Archived-At: >> I found that map-y-or-n-p uses read-event, not read-key (still the >> case in master as of 2022-10-27). Will you accept a patch if I try >> to rewrite it? [...] > Isn't there some translation map that could help you? No, `read-event` is the low-level function that gives access to the actual untranslated events. I think `map-y-or-n-p` should be changed similarly to `y-or-n-p` to use either `read-key` or the minibuffer (probably obeying `y-or-n-p-use-read-key`). Stefan