From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Tue, 03 Jan 2023 10:16:54 -0500 Message-ID: References: <87o7ri74qv.fsf@localhost> <9bc9c69ac20a37ded741@heytings.org> <9bc9c69ac282c0148962@heytings.org> <87h6x9mgdv.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40926"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60467@debbugs.gnu.org, Alan Mackenzie , Ihor Radchenko To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 03 16:18:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCj3N-000AIz-5e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 Jan 2023 16:18:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCj3D-0006XF-RA; Tue, 03 Jan 2023 10:18:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCj3C-0006Ws-GB for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 10:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCj3C-0008JE-8Q for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 10:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCj3B-0000Mq-PP for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2023 10:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Jan 2023 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.16727590281337 (code B ref 60467); Tue, 03 Jan 2023 15:18:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 3 Jan 2023 15:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:46499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCj2J-0000LU-Tx for submit@debbugs.gnu.org; Tue, 03 Jan 2023 10:17:08 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCj2F-0000Kt-GZ for 60467@debbugs.gnu.org; Tue, 03 Jan 2023 10:17:06 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 889D1100DDD; Tue, 3 Jan 2023 10:16:57 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFB57100C89; Tue, 3 Jan 2023 10:16:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672759015; bh=htWlswjezwFoQhFFxds2wabgEHSoIRyC85UnjWCD0n0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JAqCxV0fnQlJ26LP8v+PpI2Xg1zTBC7/VFEToLiZyXxJISSpjnjQFeiLvi909Zq5Q rtYqOAa5G/QCrIp8OzBZXqJUWZdNuzUlfyZO20VBvXxx6SR6JptvRTQ1lH3hDmdrC7 NxOrWc8jWTUsEdV1qCUivOtFhTrMZv/mjWxxr50TEx2uHfwYnS+3wdVPEVFzjFd0Ry a98cVCuG56P1AJTOoIovw8snF393ysCYkrCq1Rjtnv8e+r6PhBObgI3wGc8PYl/hYz fqFBzs4mebZ2SyYfHLjJMelyzc8635cbNBCunSp7d5zj2MveCZn6C5f3U12WaMEP5j ha/40eViTwCeg== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 822F4120774; Tue, 3 Jan 2023 10:16:55 -0500 (EST) In-Reply-To: (Gregory Heytings's message of "Tue, 03 Jan 2023 09:41:52 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252414 Archived-At: > nil > > ofter body has been evaluated, the buffer-undo-list after > combine-change-call is > > (apply ... #'undo--wrap-and-run-primitive-undo ... ()) > nil > > which is clearly wrong Indeed. Which begs the question: why does the current code stop when it sees a timestamp? Alan? Do you remember why you did that? What would go wrong if we applied a patch like the one below? Stefan diff --git a/lisp/subr.el b/lisp/subr.el index 5fb150994ec..6f51ac90ce5 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4972,10 +4972,11 @@ combine-change-calls-1 ;; In case garbage collection has removed OLD-BUL. (cdr ptr) ;; Don't include a timestamp entry. - (not (and (consp (cdr ptr)) - (consp (cadr ptr)) - (eq (caadr ptr) t) - (setq old-bul (cdr ptr))))) + ;; (not (and (consp (cdr ptr)) + ;; (consp (cadr ptr)) + ;; (eq (caadr ptr) t) + ;; (setq old-bul (cdr ptr)))) + ) (setq ptr (cdr ptr))) (unless (cdr ptr) (message "combine-change-calls: buffer-undo-list broken"))