From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Sat, 12 Oct 2024 19:13:49 -0400 Message-ID: References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> <69964.1728432546@alto.camomileplus.org> <86jzeh4g7x.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60423@debbugs.gnu.org, Mike Kupfer , stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 01:14:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szlK3-0000iE-1P for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 01:14:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szlJz-000542-Kg; Sat, 12 Oct 2024 19:14:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szlJx-00053n-Os for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:14:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szlJv-0002UD-W1 for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:14:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=aZJkBqHuA/cWH6cC4/IAJmf/OctBysC4Bs8rdzfwExU=; b=B3jXYJYgmC/23BDBxJSDf6Oy4eYljmgplFF1D6ozH2iv7nkz0OtcrgaABjTMwEloRRzFJo4Qa4l6VFUpRNVoB7yl0TEqz9UjZJLXX8OJu+LvaH1NiRvPTNEE6mXKrzeyMRIBY8rovia1hvbfSHKUF1xH1O6Xsdo+rR4m4pUCViRtAbmNbYL+1BcBQ76I5VWC40Bl+kPg83F4OJ4y8BMTFyOerJ8SHhu0VyEZ8sGLicZADu5RBawPSpcWsYS6mYH8xQyvymMDq5GPickTeaxUS9xhe4Of08BFW/FndM54tmYP542GYhV6O1nbGYimgYGTcHTrreEEGvA2QTZ35oHc3Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szlKA-0002xn-Jr for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2024 19:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2024 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.172877485511269 (code B ref 60423); Sat, 12 Oct 2024 23:15:02 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 12 Oct 2024 23:14:15 +0000 Original-Received: from localhost ([127.0.0.1]:38595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szlJO-0002vg-KS for submit@debbugs.gnu.org; Sat, 12 Oct 2024 19:14:14 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szlJN-0002vK-2Z for 60423@debbugs.gnu.org; Sat, 12 Oct 2024 19:14:13 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E7519443495; Sat, 12 Oct 2024 19:13:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1728774830; bh=oWRrUCSKpcX9oaUWa+pt5rCbLSfYECMI06c0BDM6wJM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XXu9febBL7BsR6tOM3L/w8d6vaJh8d+kZdWjEXi8VxsS/iKQdGN/Rk2b5WEG5AZm/ UQWd2V41UUFUf1IJAAlXYypd+wovYmLEQjjI5Qy+artAvH9ZWry8lRt7SF0CxLmGoQ L62X6wEW4CHIRYwG9bu59o2BkN+xY4cNeqpSR4SN1GDEkAvEOXu5TsBqWIWUTDwm0z YgZuGap54k+KyPXTC060X5J5kujRy3lfJcJJKPavbKkPKyXlVnssxdg4r92m7tCiQo 1ay3bFntuwuJtCfiXWcNNTvV47GB60UZ8JEK52vwyJlY7M6ldY23UO/xaoGAyY+Zup i/TUMhRf1xF2w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CE2BF443492; Sat, 12 Oct 2024 19:13:50 -0400 (EDT) Original-Received: from pastel (104-195-209-82.cpe.teksavvy.com [104.195.209.82]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8BB091205FB; Sat, 12 Oct 2024 19:13:50 -0400 (EDT) In-Reply-To: <86jzeh4g7x.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Oct 2024 15:24:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293483 Archived-At: >> So I lean towards having goto-address leave text alone (don't set an >> overlay) if it finds text properties set for the text. > > Not just any properties: only 'face' properties, right? > > I think this is okay, if we don't have better tricks up our sleeves. > I added Stefan Monnier in the hope that he could have some > suggestions. In this case the problem is that two packages compete for the same URL. I think it makes sense for goto-address to "leave text alone" in this case, but the question remains of how to detect *this* situation. The underlying text having a `face` property doesn't seem sufficient (especially since multiple `face` properties get merged, so the conflict is less severe). Maybe it should check for the presence of `help-echo and (follow-link or keymap)`? And make sure the those properties cover exactly the same chunk of text? Stefan