bug#381: save-some-buffers recursive editing entrapment

bug#381: save-some-buffers recursive editing entrapment

[jidanni]

Let's examine the trouble one can get into with
   C-x s runs the command save-some-buffers

   Type SPC or `y' to save the current buffer;
   DEL or `n' to skip the current buffer;
   RET or `q' to give up on the save (skip all remaining buffers);
   C-g to quit (cancel the whole command);
   ! to save all remaining buffers;
   C-r to view this buffer;
Yeah, that will get one entangled into both recursive editing and view
mode, try it while you are entering the reply for this message.
   d to view changes in this buffer;
Beep: "Buffer *mail* has no associated file on disc" (so don't ask in
this case); plus now we are recursive editing.
   or . (period) to save the current buffer and exit.

Make you a deal: please just add a further choice:
   g go to the current buffer (i.e., that buffer listed)
with no side effects, no marriage vows. Just put us in that buffer and
that's that.

4 out of 5 users won't know how to climb out of recursive editing, now
that there is no message about it, except for brackets in the
modeline. And even if there was a message, it would get overwritten by
the view mode message. And, recursive editing messes up gnus for me.
So my new g proposal will not tangle up the user with recursive editing.

bug#381: save-some-buffers recursive editing entrapment

[Stefan Monnier]

> Let's examine the trouble one can get into with
>    C-x s runs the command save-some-buffers

>    Type SPC or `y' to save the current buffer;
>    DEL or `n' to skip the current buffer;
>    RET or `q' to give up on the save (skip all remaining buffers);
>    C-g to quit (cancel the whole command);
>    ! to save all remaining buffers;
>    C-r to view this buffer;
> Yeah, that will get one entangled into both recursive editing and view
> mode, try it while you are entering the reply for this message.
>    d to view changes in this buffer;
> Beep: "Buffer *mail* has no associated file on disc" (so don't ask in
> this case); plus now we are recursive editing.
>    or . (period) to save the current buffer and exit.

> Make you a deal: please just add a further choice:
>    g go to the current buffer (i.e., that buffer listed)
> with no side effects, no marriage vows. Just put us in that buffer and
> that's that.

> 4 out of 5 users won't know how to climb out of recursive editing, now
> that there is no message about it, except for brackets in the
> modeline. And even if there was a message, it would get overwritten by
> the view mode message. And, recursive editing messes up gnus for me.
> So my new g proposal will not tangle up the user with recursive editing.

Indeed, the recursive edit is a bit problematic (and the `d' may not
always be applicable).  Thanks.  We'll see what we can do about it.


        Stefan

bug#381: save-some-buffers recursive editing entrapment

[Stefan Monnier]

>    C-r to view this buffer;
> Yeah, that will get one entangled into both recursive editing and view
> mode, try it while you are entering the reply for this message.

I've changed it so that recursive-edit is only used if you've set
enable-recursive-minibuffers.  Otherwise, the buffer is displayed and
you have to use scroll-other-window to navigate through it.

>    d to view changes in this buffer;
> Beep: "Buffer *mail* has no associated file on disc" (so don't ask in
> this case); plus now we are recursive editing.

Same here.  It still offers the option for non-file buffers, tho.


        Stefan