From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4117: 23.1; isearch + isearch-allow-scroll loses shift Date: Mon, 17 Aug 2009 11:07:36 -0400 Message-ID: References: <19073.19554.183166.905858@winooski.ccs.neu.edu> <87bpmkhcdb.fsf@mail.jurta.org> <19075.22351.611859.436166@winooski.ccs.neu.edu> <873a7sy73p.fsf@mail.jurta.org> <19079.19475.169507.668553@winooski.ccs.neu.edu> <8763cn1bne.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 4117@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250522833 20294 80.91.229.12 (17 Aug 2009 15:27:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Aug 2009 15:27:13 +0000 (UTC) Cc: Eli Barzilay , 4117@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 17 17:27:05 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Md46y-0000Pr-Uv for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Aug 2009 17:27:05 +0200 Original-Received: from localhost ([127.0.0.1]:45561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md46y-0005U1-61 for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Aug 2009 11:27:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md46t-0005T3-IH for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 11:26:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md46p-0005Re-2d for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 11:26:59 -0400 Original-Received: from [199.232.76.173] (port=51181 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md46n-0005RP-UQ for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 11:26:54 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45541) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md46n-0002gC-7I for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 11:26:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HFQoAX002995; Mon, 17 Aug 2009 08:26:51 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7HFF63b001075; Mon, 17 Aug 2009 08:15:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 17 Aug 2009 15:15:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4117 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4117-submit@emacsbugs.donarmstrong.com id=B4117.125052167932517 (code B ref 4117); Mon, 17 Aug 2009 15:15:06 +0000 Original-Received: (at 4117) by emacsbugs.donarmstrong.com; 17 Aug 2009 15:07:59 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HF7vTf032514 for <4117@emacsbugs.donarmstrong.com>; Mon, 17 Aug 2009 08:07:59 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhAFALcOiUpFpZNo/2dsb2JhbACBUtRghBkFh0k X-IronPort-AV: E=Sophos;i="4.43,396,1246852800"; d="scan'208";a="43660135" Original-Received: from 69-165-147-104.dsl.teksavvy.com (HELO pastel.home) ([69.165.147.104]) by ironport2-out.teksavvy.com with ESMTP; 17 Aug 2009 11:07:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3848982F0; Mon, 17 Aug 2009 11:07:36 -0400 (EDT) In-Reply-To: <8763cn1bne.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 17 Aug 2009 03:47:57 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 17 Aug 2009 11:26:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30308 Archived-At: > Index: lisp/isearch.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/isearch.el,v > retrieving revision 1.345 > diff -u -r1.345 isearch.el > --- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345 > +++ lisp/isearch.el 17 Aug 2009 00:47:38 -0000 > @@ -1900,6 +1905,12 @@ > ((and isearch-allow-scroll > (progn (setq key (isearch-reread-key-sequence-naturally keylist)) > (setq keylist (listify-key-sequence key)) > + (when this-command-keys-shift-translated > + (setq keylist (list > + (event-convert-list > + (append (cons 'shift (event-modifiers keylist)) > + (list (event-basic-type keylist)))))) > + (setq this-command-keys-shift-translated nil)) > (setq main-event (aref key 0)) > (setq scroll-command (isearch-lookup-scroll-key key)))) > ;; From this point onwards, KEY, KEYLIST and MAIN-EVENT hold a If this works, it's good, but it shouldn't be installed as is: this has no business being in isearch.el since other packages may need to do the same. Please try to abstract some useful function that we can put in subr.el and then use here in isearch.el. Stefan