From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5062: 23.1.50; image-toggle-display overwrites nxml-mode local key map Date: Sun, 29 Nov 2009 10:36:59 -0500 Message-ID: References: <87einifskr.fsf@mail.jurta.org> <87bpim8d5b.fsf@mail.jurta.org> Reply-To: Stefan Monnier , 5062@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259509667 16741 80.91.229.12 (29 Nov 2009 15:47:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Nov 2009 15:47:47 +0000 (UTC) Cc: Brent Goodrick , 5062@emacsbugs.donarmstrong.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 29 16:47:40 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NElzu-00014y-S7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Nov 2009 16:47:39 +0100 Original-Received: from localhost ([127.0.0.1]:35383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NElzu-00071g-BA for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Nov 2009 10:47:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NElzo-0006zQ-Km for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2009 10:47:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NElzj-0006rB-ED for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2009 10:47:31 -0500 Original-Received: from [199.232.76.173] (port=40096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NElzj-0006r3-6S for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2009 10:47:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47485) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NElzi-0002aq-NF for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2009 10:47:27 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nATFlNtV015619; Sun, 29 Nov 2009 07:47:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nATFj8Ov015369; Sun, 29 Nov 2009 07:45:08 -0800 Resent-Date: Sun, 29 Nov 2009 07:45:08 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 29 Nov 2009 15:45:08 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 5062 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5062-submit@emacsbugs.donarmstrong.com id=B5062.125950902714855 (code B ref 5062); Sun, 29 Nov 2009 15:45:08 +0000 Original-Received: (at 5062) by emacsbugs.donarmstrong.com; 29 Nov 2009 15:37:07 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nATFb55H014850 for <5062@emacsbugs.donarmstrong.com>; Sun, 29 Nov 2009 07:37:07 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroEAGIkEktFpYc//2dsb2JhbACBTdE4hDEEihk X-IronPort-AV: E=Sophos;i="4.47,308,1257138000"; d="scan'208";a="50280094" Original-Received: from 69-165-135-63.dsl.teksavvy.com (HELO ceviche.home) ([69.165.135.63]) by ironport2-out.pppoe.ca with ESMTP; 29 Nov 2009 10:36:59 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4AB5FB40E6; Sun, 29 Nov 2009 10:36:59 -0500 (EST) In-Reply-To: <87bpim8d5b.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 29 Nov 2009 00:54:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 29 Nov 2009 10:47:31 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33032 Archived-At: >> Better would be to save the major mode, and then switch to >> "saved-major-mode + image-minor-mode". No need to modify anybody's >> keymap. And I think that image-minor-mode should only be used while >> displaying text: basically, image-toggle-display should toggle between >> image-mode and the other major-mode (complemented with >> image-minor-mode). >> That would be cleaner, > I see now how this is implemented with `doc-view-previous-major-mode' > in doc-view. Perhaps we should "sync" this with image-mode to use > the same logic. Yes. Those two modes really need to be made more alike (ideally, they should be merged, tho there might be some good reasons to keep some of it separate). Stefan