From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#5849: 23.1.95; completion-auto-help blocks icomplete-mode Date: Sat, 24 Jul 2010 00:18:25 +0200 Message-ID: References: <87k4sfi5kp.fsf@stupidchicken.com> <2C116479CF744C2EAAAA4A28CC69F613@us.oracle.com> <87mxxbf8f5.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279924665 15833 80.91.229.12 (23 Jul 2010 22:37:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Jul 2010 22:37:45 +0000 (UTC) Cc: 5849@debbugs.gnu.org, 'Leo' To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 24 00:37:43 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OcQs8-0002e8-Bq for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Jul 2010 00:37:41 +0200 Original-Received: from localhost ([127.0.0.1]:41627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcQs5-0003pi-8u for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jul 2010 18:37:37 -0400 Original-Received: from [140.186.70.92] (port=52571 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcQrx-0003oX-AJ for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 18:37:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcQru-0002K8-Kw for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 18:37:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45515) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcQru-0002K3-IG for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 18:37:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OcQa5-0007nb-RQ; Fri, 23 Jul 2010 18:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2010 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5849-submit@debbugs.gnu.org id=B5849.127992351529948 (code B ref 5849); Fri, 23 Jul 2010 22:19:01 +0000 Original-Received: (at 5849) by debbugs.gnu.org; 23 Jul 2010 22:18:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcQZe-0007mx-1t for submit@debbugs.gnu.org; Fri, 23 Jul 2010 18:18:34 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcQZc-0007mo-8a for 5849@debbugs.gnu.org; Fri, 23 Jul 2010 18:18:32 -0400 Original-Received: from ceviche.home (vpn-132-204-232-95.acd.umontreal.ca [132.204.232.95]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o6NMIQh5013924; Fri, 23 Jul 2010 18:18:27 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id CA710660D2; Sat, 24 Jul 2010 00:18:25 +0200 (CEST) In-Reply-To: <87mxxbf8f5.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 10 Apr 2010 14:51:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3585=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 23 Jul 2010 18:19:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38853 Archived-At: > Yes, obviously this is what I meant. Like this: > === modified file 'lisp/minibuffer.el' > *** lisp/minibuffer.el 2010-03-24 18:02:56 +0000 > --- lisp/minibuffer.el 2010-04-10 18:49:41 +0000 > *************** > *** 528,536 **** > ;; Show the completion table, if requested. > (cond > ((not exact) > ! (if (case completion-auto-help > ! (lazy (eq this-command last-command)) > ! (t completion-auto-help)) > (minibuffer-completion-help) > (minibuffer-message "Next char not unique"))) > ;; If the last exact completion and this one were the same, it > --- 528,537 ---- > ;; Show the completion table, if requested. > (cond > ((not exact) > ! (if (cond (icomplete-mode t) > ! ((eq completion-auto-help 'lazy) > ! (eq this-command last-command)) > ! (t completion-auto-help)) > (minibuffer-completion-help) > (minibuffer-message "Next char not unique"))) > ;; If the last exact completion and this one were the same, it It's a good workaround, thanks. Note that most other messages from the completion code are similarly problematic, I think. So maybe we should have a buffer-local completion-inhibit-messages variable, which icomplete could set in the minibuffer. Stefan