From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8344: (substring ...) crashes on large vectors Date: Fri, 25 Mar 2011 17:24:58 -0400 Message-ID: References: <4D8CDC3A.4010705@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301089046 2116 80.91.229.12 (25 Mar 2011 21:37:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 25 Mar 2011 21:37:26 +0000 (UTC) Cc: 8344@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 25 22:37:22 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3Eh7-0006sk-9j for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Mar 2011 22:37:21 +0100 Original-Received: from localhost ([127.0.0.1]:42117 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3Eh6-0000EF-Mz for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Mar 2011 17:37:20 -0400 Original-Received: from [140.186.70.92] (port=53584 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q3Egv-0000AC-Uf for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2011 17:37:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q3Egu-0003Ha-Qm for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2011 17:37:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q3Egu-0003HV-PK for bug-gnu-emacs@gnu.org; Fri, 25 Mar 2011 17:37:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q3EWA-0005yN-CZ; Fri, 25 Mar 2011 17:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Mar 2011 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8344-submit@debbugs.gnu.org id=B8344.130108830822894 (code B ref 8344); Fri, 25 Mar 2011 21:26:02 +0000 Original-Received: (at 8344) by debbugs.gnu.org; 25 Mar 2011 21:25:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3EVG-0005xD-Gz for submit@debbugs.gnu.org; Fri, 25 Mar 2011 17:25:06 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q3EVE-0005wk-Gh for 8344@debbugs.gnu.org; Fri, 25 Mar 2011 17:25:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEABkHjU1Ld+RO/2dsb2JhbAClYXiITbsihWkElgGDSA X-IronPort-AV: E=Sophos;i="4.63,245,1299474000"; d="scan'208";a="98062386" Original-Received: from 75-119-228-78.dsl.teksavvy.com (HELO ceviche.home) ([75.119.228.78]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 25 Mar 2011 17:24:58 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 826AF660F8; Fri, 25 Mar 2011 17:24:58 -0400 (EDT) In-Reply-To: <4D8CDC3A.4010705@cs.ucla.edu> (Paul Eggert's message of "Fri, 25 Mar 2011 11:17:30 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 25 Mar 2011 17:26:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45367 Archived-At: > The problem is that (substring ...) internally calls > (vector ...), and (vector ...) cannot create a vector > whose length is 2**31 or greater, because it follows > the Emacs convention that varargs functions count the > number of arguments using an 'int'. I'm pretty sure that even with your patch such a vector would bump into all kinds of other problems. Already buffers larger than 2GB are causing troubles right now. So if you want to fix things, I'd urge you to focus on "handling an 8GB file" (on 32bit systems this won't work, but on 64bit it should but didn't last time I tried). Stefan