unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Chris Hanson <cph@chris-hanson.org>
Cc: 8454@debbugs.gnu.org
Subject: bug#8454: Themes can't work right due to design
Date: Mon, 05 Dec 2011 14:03:32 -0500	[thread overview]
Message-ID: <jwvobvm3kw1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAHiyouoXbvxu6_ceiWi12oKi9edsbtp4wFLnjS+7eJOm4eNPhw@mail.gmail.com> (Chris Hanson's message of "Sun, 4 Dec 2011 22:54:09 -0800")

> The first is that :inherit isn't very useful as a way to say "make the
> current face like the specified one".  Because color-theme clobbers
> face-defface-spec, it effectively erases any previous face settings,
> so that the theme settings are self-contained.  There is no equivalent
> way to do this with custom-theme, which has led me to write things
> like `(font-lock-type-face ,zenburn-primary-3) rather than
> `(font-lock-type-face ((t (:inherit zenburn-primary-3)))) .  This
> works but is somewhat unsatisfying.

I don't really understand the problem here, probably because I'm not
sufficiently versed in themes, but just in case, you may want to give
a more specific example of what behavior you're trying to get, what you
tried (presumably something like ((t (:inherit foo)))) and what you
don't like about the resulting behavior.

> The second is that a face attribute that's explicitly set can't be
> overridden by a custom theme, for reasons I'm not completely clear on.

That's the way the interaction between custom settings and Lisp settings
are defined, because it seems like the only "sane" way to handle it.

>  For example, "cc-fonts.el" contains (set-face-foreground
> 'c-annotation-face "blue")

Probably something that should be fixed.


        Stefan





  parent reply	other threads:[~2011-12-05 19:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-09  3:51 bug#8454: 24.0; Emacs does not apply additional custom faces from theme Christoph Scholtes
2011-10-23 16:58 ` bug#8454: I can't reproduce this Dave Abrahams
2011-12-05  6:54 ` bug#8454: Themes can't work right due to design Chris Hanson
2011-12-05 17:52   ` Drew Adams
2011-12-05 19:03   ` Stefan Monnier [this message]
2011-12-06  2:22     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvobvm3kw1.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8454@debbugs.gnu.org \
    --cc=cph@chris-hanson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).