* bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working
@ 2012-09-11 18:44 Jose Marino
2012-09-12 8:06 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Jose Marino @ 2012-09-11 18:44 UTC (permalink / raw)
To: 12418
I'm using idlwave mode with emacs 24.2 and filename completion in the
shell is not working. Typing TAB produces nothing: no errors and no
completions.
The problem seems to be fixed by this patch:
--- idlw-shell.el.orig 2012-09-11 13:35:35.549891109 -0500
+++ idlw-shell.el 2012-09-11 13:36:37.901886841 -0500
@@ -2187,7 +2187,7 @@
;; CWD might have changed, resync, to set default directory
(idlwave-shell-resync-dirs)
(let ((comint-file-name-chars idlwave-shell-file-name-chars))
- (comint-filename-completion)))
+ (comint-dynamic-complete-filename)))
(defun idlwave-shell-executive-command ()
"Return the name of the current executive command, if any."
Thanks,
Jose
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working
2012-09-11 18:44 bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working Jose Marino
@ 2012-09-12 8:06 ` Glenn Morris
2012-09-13 12:36 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2012-09-12 8:06 UTC (permalink / raw)
To: 12418-done
Version: 24.3
Jose Marino wrote:
> - (comint-filename-completion)))
> + (comint-dynamic-complete-filename)))
Thanks; applied to emacs-24 branch.
The obsolescence message for comint-dynamic-complete-as-filename seems
misleading to me:
This function is obsolete since 24.1;
use `comint-filename-completion' instead.
Surely it would be better to say `use comint-dynamic-complete-filename
instead', rather than just saying "See `comint-dynamic-complete-filename'"
in the doc.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working
2012-09-12 8:06 ` Glenn Morris
@ 2012-09-13 12:36 ` Stefan Monnier
2012-09-13 18:24 ` Glenn Morris
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2012-09-13 12:36 UTC (permalink / raw)
To: 12418
>> - (comint-filename-completion)))
>> + (comint-dynamic-complete-filename)))
> The obsolescence message for comint-dynamic-complete-as-filename seems
> misleading to me:
> This function is obsolete since 24.1;
> use `comint-filename-completion' instead.
> Surely it would be better to say `use comint-dynamic-complete-filename
> instead',
Actually, that depends on what comint-dynamic-complete-as-filename was
used for: if it was used as a *command*, then
comint-dynamic-complete-filename is a good replacement. But if it was
used within something like comint-dynamic-complete-functions, then the
better replacement is comint-filename-completion.
IOW, in the case of idlw-shell.el, the better replacement is indeed
comint-filename-completion, tho it requires changes in
idlwave-shell-complete (basically making it an alias to
completion-at-point and turning its body into a list of functions to put
on completion-at-point-functions).
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working
2012-09-13 12:36 ` Stefan Monnier
@ 2012-09-13 18:24 ` Glenn Morris
2012-09-14 1:17 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2012-09-13 18:24 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 12418
Stefan Monnier wrote:
> Actually, that depends on what comint-dynamic-complete-as-filename was
> used for: if it was used as a *command*, then
> comint-dynamic-complete-filename is a good replacement. But if it was
> used within something like comint-dynamic-complete-functions, then the
> better replacement is comint-filename-completion.
Could you make the obsolescence message less definitive-sounding then?
> IOW, in the case of idlw-shell.el, the better replacement is indeed
> comint-filename-completion, tho it requires changes in
> idlwave-shell-complete (basically making it an alias to
> completion-at-point and turning its body into a list of functions to put
> on completion-at-point-functions).
Hopefully you feel like doing that (or reopening this report).
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working
2012-09-13 18:24 ` Glenn Morris
@ 2012-09-14 1:17 ` Stefan Monnier
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2012-09-14 1:17 UTC (permalink / raw)
To: Glenn Morris; +Cc: 12418
>> Actually, that depends on what comint-dynamic-complete-as-filename was
>> used for: if it was used as a *command*, then
>> comint-dynamic-complete-filename is a good replacement. But if it was
>> used within something like comint-dynamic-complete-functions, then the
>> better replacement is comint-filename-completion.
> Could you make the obsolescence message less definitive-sounding then?
I don't think it's worth the trouble: the use of
comint-dynamic-complete-filename is very rare.
>> IOW, in the case of idlw-shell.el, the better replacement is indeed
>> comint-filename-completion, tho it requires changes in
>> idlwave-shell-complete (basically making it an alias to
>> completion-at-point and turning its body into a list of functions to put
>> on completion-at-point-functions).
> Hopefully you feel like doing that (or reopening this report).
I don't really feel like it, but I will probably be the first to get to
it, regardless of how slowly I do it :-(
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-14 1:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11 18:44 bug#12418: emacs 24.2; idlw-shell.el: filename completion in IDL shell is not working Jose Marino
2012-09-12 8:06 ` Glenn Morris
2012-09-13 12:36 ` Stefan Monnier
2012-09-13 18:24 ` Glenn Morris
2012-09-14 1:17 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).