bug#12858: 24.3.50; Critical: advice broken

bug#12858: 24.3.50; Critical: advice broken

[Michael Heerdegen]

Hello,

after upgrading my Emacs to "GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu,
GTK+ Version 3.4.2)\n of 2012-11-09 on dex, modified by Debian", it is
completely unusable here with my setup.

Somehow, the advice package is seriously damaged.

After I started with my setup, I got this:

Debugger entered--Lisp error: (wrong-type-argument symbolp #[(package-list requirements) "\303\304	!\305	!\210\306
	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-real-orig-definition(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad--make-advised-docstring(#("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring)) #[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-real-documentation(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))] t)
  ad-docstring(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-advised-definition-p(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-handle-definition(package-compute-transaction)
  ad-activate(package-compute-transaction t)
  byte-code("\300\301\302\303\304\305\306\307&\a\210\300\310\302\311\304\305\306\312&\a\210\300\313\314\315\304\305\306\316&\a\210\317\320\321\322\302$\210\323\320\324\"\210\317\325\326\327\302$\210\323\325\324\"\207" [custom-declare-variable package-archive-enable-alist nil "Optional Alist of enabled packages used by `package-filter'.\nThe format is (ARCHIVE . PACKAGE ...), where ARCHIVE is a string\nmatching an archive name in `package-archives', PACKAGE is a\nsymbol of a package in ARCHIVE to enable.\n\nIf no ARCHIVE exists in the alist, all packages are enabled." :group package :type (alist :key-type string :value-type (repeat symbol)) package-archive-exclude-alist "Alist of packages excluded by `package-filter'.\nThe format is (ARCHIVE . PACKAGE ...), where ARCHIVE is a string\nmatching an archive name in `package-archives', PACKAGE is a\nsymbol of a package in that archive to exclude.\n\nAny specified package is excluded regardless of the value of\n`package-archive-enable-alist'" (alist :key-type string :value-type (repeat symbol)) package-filter-function (quote package-filter) "Optional predicate function used to internally\nfilter packages used by package.el.\n\nReturn nil to filter a function from the list.\n\nThe function is called with the arguments PACKAGE VERSION ARCHIVE, where\nPACKAGE is a symbol, VERSION is a vector as produced by `version-to-list', and\nARCHIVE is the string name of the package archive." function ad-add-advice package-compute-transaction (package-compute-transaction-reverse nil t (advice lambda (package-list requirements) "reverse the requirements" (setq requirements (reverse requirements)) (print requirements))) before ad-activate t package--add-to-archive-contents (package-filter-add-to-archive-contents nil t (advice lambda (package archive) "Add filtering of available packages using `package-filter-function',\nif non-nil." (when (and package-filter-function (funcall package-filter-function (car package) (package-desc-vers (cdr package)) archive)) ad-do-it))) around] 8)
  package-filter(ack (0 8) "gnu")
  package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  package-read-archive-contents("gnu")
  package-read-all-archive-contents()
  package-initialize()
  command-line()
  normal-top-level()

I get other such errors if I try to load other parts of my setup, like
this:

Debugger entered--Lisp error: (wrong-type-argument symbolp #[(beg end) "\303\304	
\"\212	
\211b\210`
W\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-real-orig-definition(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad--make-advised-docstring(#("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring)) #[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-real-documentation(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))] t)
  ad-docstring(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-advised-definition-p(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  ad-handle-definition(dired-insert-set-properties)
  ad-activate(dired-insert-set-properties nil)
  (progn (ad-add-advice (quote dired-insert-set-properties) (quote (provide-preview nil t (advice lambda (beg end) "Show a preview for directories." (setq ad-return-value (if (> ... ...) ad-do-it (save-excursion ... ...)))))) (quote around) (quote first)) (ad-activate (quote dired-insert-set-properties) nil) (quote dired-insert-set-properties))
  eval-buffer()  ; Reading at buffer position 235994
  call-interactively(eval-buffer record nil)
  command-execute(eval-buffer record)
  execute-extended-command(nil "eval-buffer")
  call-interactively(execute-extended-command nil nil)

I tried to help myself with doing this:

(eval-after-load 'advice
  '(defun ad-docstring (definition)
  "Return the unexpanded docstring of DEFINITION."
  "???"))

This helps a bit, but instead I get this error:

Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")
  package-filter(ack (0 8) "gnu")
  ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  [...]
  ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  package-read-archive-contents("gnu")
  package-read-all-archive-contents()
  package-initialize()
  command-line()
  normal-top-level()

At the end, Emacs has become completely unusable with my setup.  Please
help!



In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2012-11-09 on dex, modified by Debian
 (emacs-snapshot package, version 2:20121109-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
System Description:	Debian GNU/Linux testing (wheezy)

Configured using:
 `configure '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3.50/site-lisp:/usr/share/emacs/site-lisp'
 '--without-compress-info' '--with-crt-dir=/usr/lib/x86_64-linux-gnu/'
 '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes'
 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu'
 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g
 -Wl,--as-needed -znocombreloc' 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LC_ALL: de_DE.utf8
  value of $LC_TIME: C
  value of $LANG: de_DE.utf8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  recentf-mode: t
  ml-scale-mode: t
  which-function-mode: t
  display-time-mode: t
  winner-mode: t
  show-paren-mode: t
  auto-image-file-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  pretty-lambda-mode: t
  hs-org/minor-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  hs-minor-mode: t


Recent messages:
Read-Only mode disabled
Mark set
Saving file /home/micha/gnu-emacs/.gnu-emacs...
Wrote /home/micha/gnu-emacs/.gnu-emacs
Mark activated
Mark set
Auto-saving...done
Mark set
Saving file /home/micha/gnu-emacs/.gnu-emacs...
Wrote /home/micha/gnu-emacs/.gnu-emacs
byte-code: Beginning of buffer

Load-path shadows:
/home/micha/gnu-emacs/elisp/elpa/elpa hides /home/micha/gnu-emacs/elisp/elpa
/home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/gnu-emacs/elpa-icicles/hl-line+
/home/micha/gnu-emacs/elisp/col-highlight hides /home/micha/gnu-emacs/elpa-icicles/col-highlight
/home/micha/gnu-emacs/elisp/vline hides /home/micha/gnu-emacs/elpa-icicles/vline
/home/micha/gnu-emacs/elisp/icomplete+ hides /home/micha/gnu-emacs/elpa-icicles/icomplete+
/home/micha/gnu-emacs/elisp/crosshairs hides /home/micha/gnu-emacs/elpa-icicles/crosshairs
/home/micha/gnu-emacs/elisp/linkd hides /home/micha/gnu-emacs/elpa-icicles/linkd
/home/micha/gnu-emacs/elisp/fuzzy-match hides /home/micha/gnu-emacs/elpa-icicles/fuzzy-match
/home/micha/gnu-emacs/elisp/imenu+ hides /home/micha/gnu-emacs/elpa-icicles/imenu+
/home/micha/gnu-emacs/elpa-icicles/lacarte hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/lacarte
/home/micha/gnu-emacs/elpa-icicles/doremi-cmd hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-cmd
/home/micha/gnu-emacs/elpa-icicles/doremi-mac hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-mac
/home/micha/gnu-emacs/elpa-icicles/synonyms hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/synonyms
/home/micha/gnu-emacs/elpa-icicles/eyedropper hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/eyedropper
/home/micha/gnu-emacs/elpa-icicles/ring+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/ring+
/home/micha/gnu-emacs/elpa-icicles/thingatpt+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/thingatpt+
/home/micha/gnu-emacs/elisp/linkd hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/linkd
/home/micha/gnu-emacs/elpa-icicles/frame-fns hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/frame-fns
/home/micha/gnu-emacs/elpa-icicles/faces+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/faces+
/home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/hl-line+
/home/micha/gnu-emacs/elisp/fuzzy-match hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/fuzzy-match
/home/micha/gnu-emacs/elpa-icicles/mb-depth+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/mb-depth+
/home/micha/gnu-emacs/elisp/col-highlight hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/col-highlight
/home/micha/gnu-emacs/elpa-icicles/apropos-fn+var hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/apropos-fn+var
/home/micha/gnu-emacs/elpa-icicles/doremi-frm hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-frm
/home/micha/gnu-emacs/elisp/icomplete+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/icomplete+
/home/micha/gnu-emacs/elisp/crosshairs hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/crosshairs
/home/micha/gnu-emacs/elpa-icicles/frame-cmds hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/frame-cmds
/home/micha/gnu-emacs/elpa-icicles/doremi hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi
/home/micha/gnu-emacs/elisp/vline hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/vline
/home/micha/gnu-emacs/elpa-icicles/dired+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/dired+
/home/micha/gnu-emacs/elpa-icicles/hexrgb hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/hexrgb
/home/micha/gnu-emacs/elisp/imenu+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/imenu+
/home/micha/gnu-emacs/elisp/findr hides /home/micha/.emacs.d/elpa/findr-20120124.849/findr
/home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/.emacs.d/elpa/hl-line+-20120823.2056/hl-line+
/home/micha/gnu-emacs/elisp/htmlize hides /home/micha/.emacs.d/elpa/htmlize-20120921.1009/htmlize
/home/micha/gnu-emacs/elisp/paredit hides /home/micha/.emacs.d/elpa/paredit-20110508.1256/paredit
/usr/share/emacs-snapshot/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
/usr/share/emacs-snapshot/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
/usr/share/emacs-snapshot/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/share/emacs-snapshot/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style
/usr/share/emacs-snapshot/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex
/usr/share/emacs-snapshot/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
/usr/share/emacs-snapshot/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf
/usr/share/emacs-snapshot/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
/usr/share/emacs-snapshot/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
/usr/share/emacs-snapshot/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs
/usr/share/emacs-snapshot/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
/usr/share/emacs-snapshot/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
/usr/share/emacs-snapshot/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
/usr/share/emacs-snapshot/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
/usr/share/emacs-snapshot/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
/usr/share/emacs-snapshot/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
/usr/share/emacs-snapshot/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/share/emacs-snapshot/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
/usr/share/emacs-snapshot/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview
/usr/share/emacs-snapshot/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
/usr/share/emacs-snapshot/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite
/usr/share/emacs/24.3.50/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs-snapshot/site-lisp/flim/md4 hides /usr/share/emacs/24.3.50/lisp/md4
/usr/share/emacs-snapshot/site-lisp/flim/hex-util hides /usr/share/emacs/24.3.50/lisp/hex-util
/home/micha/gnu-emacs/loaddefs hides /usr/share/emacs/24.3.50/lisp/loaddefs
/usr/share/emacs-snapshot/site-lisp/flim/sasl-cram hides /usr/share/emacs/24.3.50/lisp/net/sasl-cram
/usr/share/emacs-snapshot/site-lisp/flim/sasl hides /usr/share/emacs/24.3.50/lisp/net/sasl
/usr/share/emacs-snapshot/site-lisp/flim/hmac-md5 hides /usr/share/emacs/24.3.50/lisp/net/hmac-md5
/usr/share/emacs-snapshot/site-lisp/flim/sasl-digest hides /usr/share/emacs/24.3.50/lisp/net/sasl-digest
/usr/share/emacs-snapshot/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/24.3.50/lisp/net/sasl-ntlm
/usr/share/emacs-snapshot/site-lisp/flim/hmac-def hides /usr/share/emacs/24.3.50/lisp/net/hmac-def
/usr/share/emacs-snapshot/site-lisp/flim/ntlm hides /usr/share/emacs/24.3.50/lisp/net/ntlm

Features:
(shadow sort gnus-cite bbdb-message mail-extr emacsbug sendmail qp
gnus-salt gnus-ml nndraft nnmh gnus-agent gnus-srvr gnus-score
score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime dig mailcap rot13 disp-table nnfolder utf-7 gnus-cache gnus-sum
bbdb timezone gnutls network-stream starttls nnimap parse-time tls utf7
netrc nntp gnus-group gnus-undo nnmail mail-source nnoo gnus-start
gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader
mail-utils wdired deeper-blue-theme cus-theme paredit uniquify recentf
tree-widget foldout org-protocol org ob-tangle ob-ref ob-lob ob-table
org-footnote org-src ob-comint ob-keys org-pcomplete pcomplete comint
ansi-color org-list org-faces org-entities noutline outline org-version
ob-emacs-lisp ob org-compat org-macs ob-eval org-loaddefs face-remap
ml-scale melpa misearch multi-isearch mule-util add-log view two-column
appt diary-lib diary-loaddefs diary-general cal-iso cal-menu calendar
cal-loaddefs epa-file epa epg epg-config server which-func time winner
paren delsel image-file wide-n undo-tree diff rainbow-delimiters
pretty-lambdada pinbar linkd imenu+ imenu icomplete+ icicles-mac lacarte
icicles icicles-mode dired+ ediff-merg ediff-diff ediff-wind ediff-mult
ediff-help ediff-init ediff-util dired-aux mb-depth+ mb-depth
icicles-cmd2 icicles-cmd1 frame-cmds cus-edit icicles-mcmd mouse3
image-dired format-spec doremi ring+ ring icicles-fn icicles-var
apropos-fn+var apropos icicles-opt wid-edit icicles-face hexrgb
highlight frame-fns avoid hideshow-org edmacro folding-isearch folding
emacs-lock+ emacs-lock elpa assoc debug eldoc-eval eldoc dired-hide
buff-menu+ bookmark+ bookmark+-key easy-mmode dired-x dired bookmark+-1
thingatpt+ bookmark+-bmu help-mode bookmark+-lit bookmark pp autofold
hideshow automenu loadhist auto-dictionary flyspell ispell apt-utils
jka-compr browse-url derived icomplete cus-start cus-load
anti-zenburn-theme-autoloads bbdb-autoloads
birds-of-paradise-plus-theme-autoloads bookmark+-autoloads
cyberpunk-theme-autoloads debbugs-autoloads eldoc-eval-autoloads
elpa-icicles-autoloads elscreen-autoloads findr-autoloads
gnuplot-autoloads hl-line+-autoloads htmlize-autoloads icicles-autoloads
kmacro fuzzy-match el-swank-fuzzy lib-requires-autoloads melpa-autoloads
paredit-autoloads quarter-plane-autoloads rainbow-delimiters-autoloads
sicp-autoloads info easymenu solarized-theme-autoloads
underwater-theme-autoloads undo-tree-autoloads
zen-and-art-theme-autoloads thingatpt finder finder-inf find-func
lisp-mnt package cl-macs gv rx crosshairs col-highlight vline hl-line+
hl-line mh-elisp-utils ffap url-parse auth-source eieio byte-opt
bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache
url-vars advice advice-preload autoload help-fns cl cl-lib warnings
debian-el debian-el-loaddefs w3m-load preview-latex tex-site auto-loads
time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

> after upgrading my Emacs to "GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu,
> GTK+ Version 3.4.2)\n of 2012-11-09 on dex, modified by Debian", it is
> completely unusable here with my setup.

I haven't had time to look at your bug report(s) yet, but I recommend
you follow the `emacs-24' branch now that we've moved the pretest
code there.
This will help us fix bugs before the 24.3 release.
Also this will save you from the bugs on the trunk, since the trunk is
now less stable.


        Stefan

bug#12858: 24.3.50; Critical: advice broken

[Michael Heerdegen]

Hello Stefan,

> I haven't had time to look at your bug report(s) yet, but I recommend
> you follow the `emacs-24' branch now that we've moved the pretest
> code there.
> This will help us fix bugs before the 24.3 release.
> Also this will save you from the bugs on the trunk, since the trunk is
> now less stable.

Stability isn't critical for me, as I don't need Emacs for my job or
such.  Although this was a bad surprise last night.

Question: If we neglect stability - is it more helpful for Emacs dev
when I use the emacs-24 branch and "search" bugs there?  Or did you mean
that it would be mainly better for me?


Regards,

Michael.

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

> Question: If we neglect stability - is it more helpful for Emacs dev
> when I use the emacs-24 branch and "search" bugs there?

Yes, since we're in pretest, finding bugs in emacs-24 is
particularly important.


        Stefan

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

You might try your advice code with the new code in trunk.
There are significant changes in there, so I suspect the bug you suffered
from is gone, but I wouldn't be surprised if it is replaced by others.


        Stefan

bug#12858: 24.3.50; Critical: advice broken

[Vitalie Spinu]

Same here, my anything and sunrise setup are completely unusable:

   Debugger entered--Lisp error: (wrong-type-argument symbolp #[(dirname &optional mode) "\304\305	
   \"\203\v\306\307
   \v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
     ad-real-orig-definition(#[(dirname &optional mode) "\304\305	\n\"\203\v\306\307\n\v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
     ad--make-advised-docstring(#("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring)) #[(dirname &optional mode) "\304\305	\n\"\203\v\306\307\n\v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
     ad-real-documentation(#[(dirname &optional mode) "\304\305	\n\"\203\v\306\307\n\v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))] t)
     ad-docstring(#[(dirname &optional mode) "\304\305	\n\"\203\v\306\307\n\v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
     ad-advised-definition-p(#[(dirname &optional mode) "\304\305	\n\"\203\v\306\307\n\v\"\211)\207" [ad-return-value sr-dired-directory dirname mode nil sr-equal-dirs sr-mode ad-Orig-dired-find-buffer-nocreate] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
     ad-handle-definition(dired-find-buffer-nocreate)
     ad-activate(dired-find-buffer-nocreate)
     sr-goto-dir("/home/vitoshka/")
     sr-dired("~/")
     sr-setup-visible-panes()
     sr-popviewer-setup-windows()
     sr-setup-windows()
     sunrise()
     sr-dired("/home/vitoshka/Dropbox/.main/News/drafts/drafts/172")
     ad-Orig-sunrise-cd()
     sunrise-cd()
     call-interactively(sunrise-cd nil nil)

GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2) of
2012-11-09 on menkib, modified by Debian


  >> Michael Heerdegen <michael_heerdegen@web.de>
  >> on Sun, 11 Nov 2012 02:26:46 +0100 wrote:

  MH> Hello,
  MH> after upgrading my Emacs to "GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu,
  MH> GTK+ Version 3.4.2)\n of 2012-11-09 on dex, modified by Debian", it is
  MH> completely unusable here with my setup.

  MH> Somehow, the advice package is seriously damaged.

  MH> After I started with my setup, I got this:

  MH> Debugger entered--Lisp error: (wrong-type-argument symbolp #[(package-list requirements) "\303\304	!\305	!\210\306
  MH> 	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-real-orig-definition(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad--make-advised-docstring(#("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring)) #[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-real-documentation(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))] t)
  MH>   ad-docstring(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-advised-definition-p(#[(package-list requirements) "\303\304	!\305	!\210\306\n	\"\211)\207" [ad-return-value requirements package-list nil reverse print ad-Orig-package-compute-transaction] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-handle-definition(package-compute-transaction)
  MH>   ad-activate(package-compute-transaction t)
  MH>   byte-code("\300\301\302\303\304\305\306\307&\a\210\300\310\302\311\304\305\306\312&\a\210\300\313\314\315\304\305\306\316&\a\210\317\320\321\322\302$\210\323\320\324\"\210\317\325\326\327\302$\210\323\325\324\"\207" [custom-declare-variable package-archive-enable-alist nil "Optional Alist of enabled packages used by `package-filter'.\nThe format is (ARCHIVE . PACKAGE ...), where ARCHIVE is a string\nmatching an archive name in `package-archives', PACKAGE is a\nsymbol of a package in ARCHIVE to enable.\n\nIf no ARCHIVE exists in the alist, all packages are enabled." :group package :type (alist :key-type string :value-type (repeat symbol)) package-archive-exclude-alist "Alist of packages excluded by `package-filter'.\nThe format is (ARCHIVE . PACKAGE ...), where ARCHIVE is a string\nmatching an archive name in `package-archives', PACKAGE is a\nsymbol of a package in that archive to exclude.\n\nAny specified package is excluded regardless of the value of\n`package-archive-enable-alist'" (alist :key-type string :value-type (repeat symbol)) package-filter-function (quote package-filter) "Optional predicate function used to internally\nfilter packages used by package.el.\n\nReturn nil to filter a function from the list.\n\nThe function is called with the arguments PACKAGE VERSION ARCHIVE, where\nPACKAGE is a symbol, VERSION is a vector as produced by `version-to-list', and\nARCHIVE is the string name of the package archive." function ad-add-advice package-compute-transaction (package-compute-transaction-reverse nil t (advice lambda (package-list requirements) "reverse the requirements" (setq requirements (reverse requirements)) (print requirements))) before ad-activate t package--add-to-archive-contents (package-filter-add-to-archive-contents nil t (advice lambda (package archive) "Add filtering of available packages using `package-filter-function',\nif non-nil." (when (and package-filter-function (funcall package-filter-function (car package) (package-desc-vers (cdr package)) archive)) ad-do-it))) around] 8)
  MH>   package-filter(ack (0 8) "gnu")
  MH>   package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  MH>   package-read-archive-contents("gnu")
  MH>   package-read-all-archive-contents()
  MH>   package-initialize()
  MH>   command-line()
  MH>   normal-top-level()

  MH> I get other such errors if I try to load other parts of my setup, like
  MH> this:

  MH> Debugger entered--Lisp error: (wrong-type-argument symbolp #[(beg end) "\303\304	
  MH> \"\212	
  MH> \211b\210`
  MH> W\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-real-orig-definition(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad--make-advised-docstring(#("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring)) #[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-real-documentation(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))] t)
  MH>   ad-docstring(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-advised-definition-p(#[(beg end) "\303\304	\n\"\212	\n\211b\210`\nW\203\305 \210\306y\210\202+\b)\207" [ad-return-value beg end nil ad-Orig-dired-insert-set-properties dired-hide-prepare-line 1] 4 #("Advice doc string" 0 17 (dynamic-docstring-function ad--make-advised-docstring))])
  MH>   ad-handle-definition(dired-insert-set-properties)
  MH>   ad-activate(dired-insert-set-properties nil)
  MH>   (progn (ad-add-advice (quote dired-insert-set-properties) (quote (provide-preview nil t (advice lambda (beg end) "Show a preview for directories." (setq ad-return-value (if (> ... ...) ad-do-it (save-excursion ... ...)))))) (quote around) (quote first)) (ad-activate (quote dired-insert-set-properties) nil) (quote dired-insert-set-properties))
  MH>   eval-buffer()  ; Reading at buffer position 235994
  MH>   call-interactively(eval-buffer record nil)
  MH>   command-execute(eval-buffer record)
  MH>   execute-extended-command(nil "eval-buffer")
  MH>   call-interactively(execute-extended-command nil nil)

  MH> I tried to help myself with doing this:

  MH> (eval-after-load 'advice
  MH>   '(defun ad-docstring (definition)
  MH>   "Return the unexpanded docstring of DEFINITION."
  MH>   "???"))

  MH> This helps a bit, but instead I get this error:

  MH> Debugger entered--Lisp error: (error "Lisp nesting exceeds `max-lisp-eval-depth'")
  MH>   package-filter(ack (0 8) "gnu")
  MH>   ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  MH>   [...]
  MH>   ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  MH>   ad-Orig-package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  MH>   package--add-to-archive-contents((ack . [(0 8) nil "Interface to ack, a source code search tool" tar]) "gnu")
  MH>   package-read-archive-contents("gnu")
  MH>   package-read-all-archive-contents()
  MH>   package-initialize()
  MH>   command-line()
  MH>   normal-top-level()

  MH> At the end, Emacs has become completely unusable with my setup.  Please
  MH> help!

  MH> In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2)
  MH>  of 2012-11-09 on dex, modified by Debian
  MH>  (emacs-snapshot package, version 2:20121109-1)
  MH> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
  MH> System Description:	Debian GNU/Linux testing (wheezy)

  MH> Configured using:
  MH>  `configure '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu'
  MH>  '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
  MH>  '--localstatedir=/var' '--infodir=/usr/share/info'
  MH>  '--mandir=/usr/share/man' '--with-pop=yes'
  MH>  '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3.50/site-lisp:/usr/share/emacs/site-lisp'
  MH>  '--without-compress-info' '--with-crt-dir=/usr/lib/x86_64-linux-gnu/'
  MH>  '--with-x=yes' '--with-x-toolkit=gtk3' '--with-imagemagick=yes'
  MH>  'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu'
  MH>  'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g
  MH>  -Wl,--as-needed -znocombreloc' 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

  MH> Important settings:
  MH>   value of $LC_ALL: de_DE.utf8
  MH>   value of $LC_TIME: C
  MH>   value of $LANG: de_DE.utf8
  MH>   locale-coding-system: utf-8-unix
  MH>   default enable-multibyte-characters: t

  MH> Major mode: Emacs-Lisp

  MH> Minor modes in effect:
  MH>   recentf-mode: t
  MH>   ml-scale-mode: t
  MH>   which-function-mode: t
  MH>   display-time-mode: t
  MH>   winner-mode: t
  MH>   show-paren-mode: t
  MH>   auto-image-file-mode: t
  MH>   global-undo-tree-mode: t
  MH>   undo-tree-mode: t
  MH>   pretty-lambda-mode: t
  MH>   hs-org/minor-mode: t
  MH>   tooltip-mode: t
  MH>   mouse-wheel-mode: t
  MH>   menu-bar-mode: t
  MH>   file-name-shadow-mode: t
  MH>   global-font-lock-mode: t
  MH>   font-lock-mode: t
  MH>   blink-cursor-mode: t
  MH>   auto-composition-mode: t
  MH>   auto-encryption-mode: t
  MH>   auto-compression-mode: t
  MH>   column-number-mode: t
  MH>   line-number-mode: t
  MH>   transient-mark-mode: t
  MH>   hs-minor-mode: t

  MH> Recent messages:
  MH> Read-Only mode disabled
  MH> Mark set
  MH> Saving file /home/micha/gnu-emacs/.gnu-emacs...
  MH> Wrote /home/micha/gnu-emacs/.gnu-emacs
  MH> Mark activated
  MH> Mark set
  MH> Auto-saving...done
  MH> Mark set
  MH> Saving file /home/micha/gnu-emacs/.gnu-emacs...
  MH> Wrote /home/micha/gnu-emacs/.gnu-emacs
  MH> byte-code: Beginning of buffer

  MH> Load-path shadows:
  MH> /home/micha/gnu-emacs/elisp/elpa/elpa hides /home/micha/gnu-emacs/elisp/elpa
  MH> /home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/gnu-emacs/elpa-icicles/hl-line+
  MH> /home/micha/gnu-emacs/elisp/col-highlight hides /home/micha/gnu-emacs/elpa-icicles/col-highlight
  MH> /home/micha/gnu-emacs/elisp/vline hides /home/micha/gnu-emacs/elpa-icicles/vline
  MH> /home/micha/gnu-emacs/elisp/icomplete+ hides /home/micha/gnu-emacs/elpa-icicles/icomplete+
  MH> /home/micha/gnu-emacs/elisp/crosshairs hides /home/micha/gnu-emacs/elpa-icicles/crosshairs
  MH> /home/micha/gnu-emacs/elisp/linkd hides /home/micha/gnu-emacs/elpa-icicles/linkd
  MH> /home/micha/gnu-emacs/elisp/fuzzy-match hides /home/micha/gnu-emacs/elpa-icicles/fuzzy-match
  MH> /home/micha/gnu-emacs/elisp/imenu+ hides /home/micha/gnu-emacs/elpa-icicles/imenu+
  MH> /home/micha/gnu-emacs/elpa-icicles/lacarte hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/lacarte
  MH> /home/micha/gnu-emacs/elpa-icicles/doremi-cmd hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-cmd
  MH> /home/micha/gnu-emacs/elpa-icicles/doremi-mac hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-mac
  MH> /home/micha/gnu-emacs/elpa-icicles/synonyms hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/synonyms
  MH> /home/micha/gnu-emacs/elpa-icicles/eyedropper hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/eyedropper
  MH> /home/micha/gnu-emacs/elpa-icicles/ring+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/ring+
  MH> /home/micha/gnu-emacs/elpa-icicles/thingatpt+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/thingatpt+
  MH> /home/micha/gnu-emacs/elisp/linkd hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/linkd
  MH> /home/micha/gnu-emacs/elpa-icicles/frame-fns hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/frame-fns
  MH> /home/micha/gnu-emacs/elpa-icicles/faces+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/faces+
  MH> /home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/hl-line+
  MH> /home/micha/gnu-emacs/elisp/fuzzy-match hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/fuzzy-match
  MH> /home/micha/gnu-emacs/elpa-icicles/mb-depth+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/mb-depth+
  MH> /home/micha/gnu-emacs/elisp/col-highlight hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/col-highlight
  MH> /home/micha/gnu-emacs/elpa-icicles/apropos-fn+var hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/apropos-fn+var
  MH> /home/micha/gnu-emacs/elpa-icicles/doremi-frm hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi-frm
  MH> /home/micha/gnu-emacs/elisp/icomplete+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/icomplete+
  MH> /home/micha/gnu-emacs/elisp/crosshairs hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/crosshairs
  MH> /home/micha/gnu-emacs/elpa-icicles/frame-cmds hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/frame-cmds
  MH> /home/micha/gnu-emacs/elpa-icicles/doremi hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/doremi
  MH> /home/micha/gnu-emacs/elisp/vline hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/vline
  MH> /home/micha/gnu-emacs/elpa-icicles/dired+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/dired+
  MH> /home/micha/gnu-emacs/elpa-icicles/hexrgb hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/hexrgb
  MH> /home/micha/gnu-emacs/elisp/imenu+ hides /home/micha/.emacs.d/elpa/elpa-icicles-20110109/imenu+
  MH> /home/micha/gnu-emacs/elisp/findr hides /home/micha/.emacs.d/elpa/findr-20120124.849/findr
  MH> /home/micha/gnu-emacs/elisp/hl-line+ hides /home/micha/.emacs.d/elpa/hl-line+-20120823.2056/hl-line+
  MH> /home/micha/gnu-emacs/elisp/htmlize hides /home/micha/.emacs.d/elpa/htmlize-20120921.1009/htmlize
  MH> /home/micha/gnu-emacs/elisp/paredit hides /home/micha/.emacs.d/elpa/paredit-20110508.1256/paredit
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
  MH> /usr/share/emacs-snapshot/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite
  MH> /usr/share/emacs/24.3.50/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
  MH> /usr/share/emacs-snapshot/site-lisp/flim/md4 hides /usr/share/emacs/24.3.50/lisp/md4
  MH> /usr/share/emacs-snapshot/site-lisp/flim/hex-util hides /usr/share/emacs/24.3.50/lisp/hex-util
  MH> /home/micha/gnu-emacs/loaddefs hides /usr/share/emacs/24.3.50/lisp/loaddefs
  MH> /usr/share/emacs-snapshot/site-lisp/flim/sasl-cram hides /usr/share/emacs/24.3.50/lisp/net/sasl-cram
  MH> /usr/share/emacs-snapshot/site-lisp/flim/sasl hides /usr/share/emacs/24.3.50/lisp/net/sasl
  MH> /usr/share/emacs-snapshot/site-lisp/flim/hmac-md5 hides /usr/share/emacs/24.3.50/lisp/net/hmac-md5
  MH> /usr/share/emacs-snapshot/site-lisp/flim/sasl-digest hides /usr/share/emacs/24.3.50/lisp/net/sasl-digest
  MH> /usr/share/emacs-snapshot/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/24.3.50/lisp/net/sasl-ntlm
  MH> /usr/share/emacs-snapshot/site-lisp/flim/hmac-def hides /usr/share/emacs/24.3.50/lisp/net/hmac-def
  MH> /usr/share/emacs-snapshot/site-lisp/flim/ntlm hides /usr/share/emacs/24.3.50/lisp/net/ntlm

  MH> Features:
  MH> (shadow sort gnus-cite bbdb-message mail-extr emacsbug sendmail qp
  MH> gnus-salt gnus-ml nndraft nnmh gnus-agent gnus-srvr gnus-score
  MH> score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
  MH> smime dig mailcap rot13 disp-table nnfolder utf-7 gnus-cache gnus-sum
  MH> bbdb timezone gnutls network-stream starttls nnimap parse-time tls utf7
  MH> netrc nntp gnus-group gnus-undo nnmail mail-source nnoo gnus-start
  MH> gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode
  MH> mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
  MH> mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader
  MH> mail-utils wdired deeper-blue-theme cus-theme paredit uniquify recentf
  MH> tree-widget foldout org-protocol org ob-tangle ob-ref ob-lob ob-table
  MH> org-footnote org-src ob-comint ob-keys org-pcomplete pcomplete comint
  MH> ansi-color org-list org-faces org-entities noutline outline org-version
  MH> ob-emacs-lisp ob org-compat org-macs ob-eval org-loaddefs face-remap
  MH> ml-scale melpa misearch multi-isearch mule-util add-log view two-column
  MH> appt diary-lib diary-loaddefs diary-general cal-iso cal-menu calendar
  MH> cal-loaddefs epa-file epa epg epg-config server which-func time winner
  MH> paren delsel image-file wide-n undo-tree diff rainbow-delimiters
  MH> pretty-lambdada pinbar linkd imenu+ imenu icomplete+ icicles-mac lacarte
  MH> icicles icicles-mode dired+ ediff-merg ediff-diff ediff-wind ediff-mult
  MH> ediff-help ediff-init ediff-util dired-aux mb-depth+ mb-depth
  MH> icicles-cmd2 icicles-cmd1 frame-cmds cus-edit icicles-mcmd mouse3
  MH> image-dired format-spec doremi ring+ ring icicles-fn icicles-var
  MH> apropos-fn+var apropos icicles-opt wid-edit icicles-face hexrgb
  MH> highlight frame-fns avoid hideshow-org edmacro folding-isearch folding
  MH> emacs-lock+ emacs-lock elpa assoc debug eldoc-eval eldoc dired-hide
  MH> buff-menu+ bookmark+ bookmark+-key easy-mmode dired-x dired bookmark+-1
  MH> thingatpt+ bookmark+-bmu help-mode bookmark+-lit bookmark pp autofold
  MH> hideshow automenu loadhist auto-dictionary flyspell ispell apt-utils
  MH> jka-compr browse-url derived icomplete cus-start cus-load
  MH> anti-zenburn-theme-autoloads bbdb-autoloads
  MH> birds-of-paradise-plus-theme-autoloads bookmark+-autoloads
  MH> cyberpunk-theme-autoloads debbugs-autoloads eldoc-eval-autoloads
  MH> elpa-icicles-autoloads elscreen-autoloads findr-autoloads
  MH> gnuplot-autoloads hl-line+-autoloads htmlize-autoloads icicles-autoloads
  MH> kmacro fuzzy-match el-swank-fuzzy lib-requires-autoloads melpa-autoloads
  MH> paredit-autoloads quarter-plane-autoloads rainbow-delimiters-autoloads
  MH> sicp-autoloads info easymenu solarized-theme-autoloads
  MH> underwater-theme-autoloads undo-tree-autoloads
  MH> zen-and-art-theme-autoloads thingatpt finder finder-inf find-func
  MH> lisp-mnt package cl-macs gv rx crosshairs col-highlight vline hl-line+
  MH> hl-line mh-elisp-utils ffap url-parse auth-source eieio byte-opt
  MH> bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache
  MH> url-vars advice advice-preload autoload help-fns cl cl-lib warnings
  MH> debian-el debian-el-loaddefs w3m-load preview-latex tex-site auto-loads
  MH> time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
  MH> tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
  MH> lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
  MH> mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
  MH> utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
  MH> japanese hebrew greek romanian slovak czech european ethiopic indian
  MH> cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
  MH> minibuffer loaddefs button faces cus-face macroexp files text-properties
  MH> overlay sha1 md5 base64 format env code-pages mule custom widget
  MH> hashtable-print-readable backquote make-network-process dbusbind
  MH> dynamic-setting system-font-setting font-render-setting move-toolbar gtk
  MH> x-toolkit x multi-tty emacs)

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

>      ad-handle-definition(dired-find-buffer-nocreate)
>      ad-activate(dired-find-buffer-nocreate)

The order between those two indicates you're using the "before
yesterday" code.  I installed  big change yesterday which should
introduce all kinds of new bugs (and probably fixes this bug ;-).


        Stefan

bug#12858: 24.3.50; Critical: advice broken

[Vitalie Spinu]

  >> Stefan Monnier <monnier@IRO.UMontreal.CA>
  >> on Tue, 13 Nov 2012 17:31:48 -0500 wrote:

  >> ad-handle-definition(dired-find-buffer-nocreate)
  >> ad-activate(dired-find-buffer-nocreate)

  SM> The order between those two indicates you're using the "before
  SM> yesterday" code.  I installed  big change yesterday which should
  SM> introduce all kinds of new bugs (and probably fixes this bug ;-).

I am getting the following with today's trunk:

Debugger entered--Lisp error: (wrong-type-argument listp t)
  ad-parse-arglist(t)
  ad-map-arglists(t t)
  ad-make-advised-definition(org-clock-out)
  ad-activate-advised-definition(org-clock-out nil)
  ad-activate(org-clock-out nil)
  (progn (ad-add-advice (quote org-clock-out) (quote (stack-clock-in nil t (advice lambda nil "Clock in tasks from `vs/clock-stack' on clock-out.\nClocking in the task removes t from `vs/clock-stack'.If the\nheader has :clock-ignore: tag it will be silently removed from\n`vs/clock-stack' with no clock-in." (let ((curr-clock-name org-clock-current-task) (curr-clock ...)) ad-do-it (unless org-clock-clocking-in (or ... ...)))))) (quote around) (quote nil)) (ad-activate (quote org-clock-out) nil) (quote org-clock-out))
  eval-buffer(#<buffer  *load*-582069> nil "/home/vitoshka/Dropbox/.main/.eORG.el" nil t)  ; Reading at buffer position 13539
  load-with-code-conversion("/home/vitoshka/Dropbox/.main/.eORG.el" "/home/vitoshka/Dropbox/.main/.eORG.el" nil nil)
  load(".eORG.el")
  (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el"))
  (if (> emacs-major-version 23) (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el")))
  (if (or (member "-b" command-line-args) (member "-ess" command-line-args)) nil (load custom-file) (setq package-user-dir "~/Dropbox/ELPA") (setq package-archives (quote (("gnu" . "http://elpa.gnu.org/packages/") ("marmalade" . "http://marmalade-repo.org/packages/") ("melpa" . "http://melpa.milkbox.net/packages/")))) (print "--> loading .eESS.el") (load ".eESS.el") (load "my-func.el") (if (> emacs-major-version 23) (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el"))) (cd "~/") (message "Startup took: %s" (- (float-time) (float-
 time before-init-time))))
  eval-buffer(#<buffer  *load*> nil "/home/vitoshka/.emacs" nil t)  ; Reading at buffer position 27093
  load-with-code-conversion("/home/vitoshka/.emacs" "/home/vitoshka/.emacs" t t)
  load("~/.emacs" t t)
  #[0 "\b\205\262


    Vitalie

bug#12858: 24.3.50; Critical: advice broken

[Dmitry Gutov]

Same here:

Debugger entered--Lisp error: (wrong-type-argument listp t)
   ad-parse-arglist(t)
   ad-map-arglists((pattern &optional do-all) t)
   ad-make-advised-definition(apropos)
   ad-activate-advised-definition(apropos nil)
   ad-activate(apropos nil)
   (progn (ad-add-advice (quote apropos) (quote (select-window nil t 
(advice lambda (pattern &optional do-all) "Selects apropos window and 
makes it dedicated." (let ((window ...)) (when window (select-window 
window) (set-window-dedicated-p window t)))))) (quote after) (quote 
nil)) (ad-activate (quote apropos) nil) (quote apropos))
   (defadvice apropos (after select-window (pattern &optional do-all) 
activate) "Selects apropos window and makes it dedicated." (let ((window 
(get-buffer-window "*Apropos*"))) (when window (select-window window) 
(set-window-dedicated-p window t))))
   eval((defadvice apropos (after select-window (pattern &optional 
do-all) activate) "Selects apropos window and makes it dedicated." (let 
((window (get-buffer-window "*Apropos*"))) (when window (select-window 
window) (set-window-dedicated-p window t)))) nil)
   eval-last-sexp-1(nil)
   eval-last-sexp(nil)
   call-interactively(eval-last-sexp nil nil)

bzr revno => 110899

--Dmitry

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

I've just installed a patch by Katsumi Yamaoka which might fix
this problem.
But please do use the `emacs-24' branch to help us debug Emacs-24.3.


        Stefan


>>>>> "Vitalie" == Vitalie Spinu <spinuvit@gmail.com> writes:

>>> Stefan Monnier <monnier@IRO.UMontreal.CA>
>>> on Tue, 13 Nov 2012 17:31:48 -0500 wrote:

>>> ad-handle-definition(dired-find-buffer-nocreate)
>>> ad-activate(dired-find-buffer-nocreate)

SM> The order between those two indicates you're using the "before
SM> yesterday" code.  I installed  big change yesterday which should
SM> introduce all kinds of new bugs (and probably fixes this bug ;-).

> I am getting the following with today's trunk:

> Debugger entered--Lisp error: (wrong-type-argument listp t)
>   ad-parse-arglist(t)
>   ad-map-arglists(t t)
>   ad-make-advised-definition(org-clock-out)
>   ad-activate-advised-definition(org-clock-out nil)
>   ad-activate(org-clock-out nil)
>   (progn (ad-add-advice (quote org-clock-out) (quote (stack-clock-in nil t (advice lambda nil "Clock in tasks from `vs/clock-stack' on clock-out.\nClocking in the task removes t from `vs/clock-stack'.If the\nheader has :clock-ignore: tag it will be silently removed from\n`vs/clock-stack' with no clock-in." (let ((curr-clock-name org-clock-current-task) (curr-clock ...)) ad-do-it (unless org-clock-clocking-in (or ... ...)))))) (quote around) (quote nil)) (ad-activate (quote org-clock-out) nil) (quote org-clock-out))
>   eval-buffer(#<buffer  *load*-582069> nil "/home/vitoshka/Dropbox/.main/.eORG.el" nil t)  ; Reading at buffer position 13539
>   load-with-code-conversion("/home/vitoshka/Dropbox/.main/.eORG.el" "/home/vitoshka/Dropbox/.main/.eORG.el" nil nil)
>   load(".eORG.el")
>   (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el"))
>   (if (> emacs-major-version 23) (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el")))
>   (if (or (member "-b" command-line-args) (member "-ess" command-line-args)) nil (load custom-file) (setq package-user-dir "~/Dropbox/ELPA") (setq package-archives (quote (("gnu" . "http://elpa.gnu.org/packages/") ("marmalade" . "http://marmalade-repo.org/packages/") ("melpa" . "http://melpa.milkbox.net/packages/")))) (print "--> loading .eESS.el") (load ".eESS.el") (load "my-func.el") (if (> emacs-major-version 23) (progn (package-initialize) (setq package-enable-at-startup nil) (require (quote eldoc-eval)) (global-set-key (kbd "M-x") (quote smex)) (global-set-key (kbd "M-X") (quote smex-major-mode-commands)) (paren-activate) (print "--> loading .eOTHER.el") (load ".eOTHER.el") (print "--> loading .eORG.el") (load ".eORG.el"))) (cd "~/") (message "Startup took: %s" (- (float-time) (floa
 t-time before-init-time))))
>   eval-buffer(#<buffer  *load*> nil "/home/vitoshka/.emacs" nil t)  ; Reading at buffer position 27093
>   load-with-code-conversion("/home/vitoshka/.emacs" "/home/vitoshka/.emacs" t t)
>   load("~/.emacs" t t)
>   #[0 "\b\205\262


>     Vitalie

bug#12858: 24.3.50; Critical: advice broken

[Stefan Monnier]

Should be fixed now,


        Stefan