From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Yves Baumes <ybaumes@gmail.com>, 12855@debbugs.gnu.org
Subject: bug#12855: 24.2; The Messages buffer stops following the appended lines.
Date: Mon, 12 Nov 2012 09:37:47 -0500 [thread overview]
Message-ID: <jwvobj2dh5x.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <50A0C7DA.3080001@gmx.at> (martin rudalics's message of "Mon, 12 Nov 2012 10:56:42 +0100")
> Since this bug constitutes a considerable annoyance and a regression wrt
> 23.4 I'd like to install the attached patch on the Emacs 24 branch. It
> principally only adds the necessary TYPE argument to the `copy-marker'
> calls but looks more complex because I have to do this in the right
> buffer and therefore rearranged the code a bit. OK to install?
Yes.
> - (let ((start (window-start window))
> - (point (window-point window)))
> - (setq entry
> - (cons buffer
> - (if entry
> - ;; We have an entry, update marker positions.
> - (list (set-marker (nth 1 entry) start)
> - (set-marker (nth 2 entry) point))
> - ;; Make new markers.
> - (list (copy-marker start)
> - (copy-marker point)))))
> -
> + (let* ((start
> + (if entry
> + (set-marker (nth 1 entry) (window-start window))
> + (copy-marker (window-start window))))
> + (point
> + (if entry
> + (set-marker (nth 2 entry) (window-point window))
> + (copy-marker
> + ;; Preserve window-point-insertion-type (Bug#12855).
> + (window-point) window-point-insertion-type))))
> (set-window-prev-buffers
> - window (cons entry (window-prev-buffers window))))))))
> + window
> + (cons (list buffer start point)
> + (window-prev-buffers window))))))))
I don't understand why you massaged the code this way instead of just
adding window-point-insertion-type to the last copy-marker call, but
I presume there's a good reason.
Stefan
next prev parent reply other threads:[~2012-11-12 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 19:18 bug#12855: 24.2; The Messages buffer stops following the appended lines Yves Baumes
2012-11-12 9:56 ` martin rudalics
2012-11-12 14:37 ` Stefan Monnier [this message]
2012-11-12 17:32 ` martin rudalics
2012-11-12 20:57 ` Stefan Monnier
2012-11-13 8:22 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvobj2dh5x.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=12855@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=ybaumes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).