From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#12938: 24.2; Lexical binding leaks into package-install somehow Date: Fri, 23 Nov 2012 16:50:58 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353707497 504 80.91.229.3 (23 Nov 2012 21:51:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2012 21:51:37 +0000 (UTC) Cc: 12938-done@debbugs.gnu.org To: Magnar Sveen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 23 22:51:48 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tc1A4-0001KF-JA for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2012 22:51:48 +0100 Original-Received: from localhost ([::1]:55795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tc19t-0005oG-W2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Nov 2012 16:51:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tc19r-0005no-O9 for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2012 16:51:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tc19q-0007bG-IC for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2012 16:51:35 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tc19q-0007bA-F4 for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2012 16:51:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tc1BG-00047d-3n for bug-gnu-emacs@gnu.org; Fri, 23 Nov 2012 16:53:02 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Nov 2012 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 12938@debbugs.gnu.org, monnier@iro.umontreal.ca, magnars@gmail.com Original-Received: via spool by 12938-done@debbugs.gnu.org id=D12938.135370755015805 (code D ref 12938); Fri, 23 Nov 2012 21:53:01 +0000 Original-Received: (at 12938-done) by debbugs.gnu.org; 23 Nov 2012 21:52:30 +0000 Original-Received: from localhost ([127.0.0.1]:35334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tc1Aj-00046s-Sq for submit@debbugs.gnu.org; Fri, 23 Nov 2012 16:52:30 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:56529) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tc1Ah-00046l-Q9 for 12938-done@debbugs.gnu.org; Fri, 23 Nov 2012 16:52:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FpaQ6/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA4hCmnGBWIMH X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208345493" Original-Received: from 69-165-164-58.dsl.teksavvy.com (HELO pastel.home) ([69.165.164.58]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Nov 2012 16:50:58 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 60DA4597C9; Fri, 23 Nov 2012 16:50:58 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Fri, 23 Nov 2012 16:31:23 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67376 Archived-At: > Can you test the patch below to confirm it fixes the problem for you? Forget it, that patch was at the wrong place (kill-all-local-variables) gets called soon after that, defeating this approach. I've installed the patch below instead, which seems to fix the problem. Stefan === modified file 'lisp/emacs-lisp/bytecomp.el' --- lisp/emacs-lisp/bytecomp.el 2012-11-20 19:05:20 +0000 +++ lisp/emacs-lisp/bytecomp.el 2012-11-23 21:44:46 +0000 @@ -1748,6 +1748,9 @@ ;; There may be a file local variable setting (bug#10419). (setq buffer-read-only nil filename buffer-file-name)) + ;; Don't inherit lexical-binding from caller (bug#12938). + (unless (local-variable-p 'lexical-binding) + (setq-local lexical-binding nil)) ;; Set the default directory, in case an eval-when-compile uses it. (setq default-directory (file-name-directory filename))) ;; Check if the file's local variables explicitly specify not to