unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, 14831@debbugs.gnu.org
Subject: bug#14831: cl-member warnings during bootstrap
Date: Tue, 16 Jul 2013 04:57:42 -0400	[thread overview]
Message-ID: <jwvoba2dgu7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <k2k3krwahj.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 15 Jul 2013 21:37:44 -0400")

>> I'd like to understand exactly where those `cl-member's come from.
>> I suspect the missing part is the (put 'cl-member 'compiler-macro
>> #'cl--compiler-macro-member) which is normally in cl-loaddefs.el.
>> 
>> Those residual cl-member calls may actually be a real problem, so maybe
>> this is not just a minor cosmetic fix.

> Deleting cl-loadefs.el and batch byte-compiling a file with sole contents:

> (defvar foo-bar nil)
> (add-to-list 'foo-bar 1)

> produces byte-code containing cl-member. Makes no sense to me...

Aha!  So it's the compiler-macro of add-to-list which turns an
add-to-list call into a cl-pushnew call, which is then macro-expanded to
something that uses cl-member, which should be turned into a plain
`member' by `cl--compiler-macro-member'.  So it can be fixed by changing
the compiler-macro of add-to-list not to use cl-pushnew.


        Stefan





  reply	other threads:[~2013-07-16  8:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 14:42 bug#14831: cl-member warnings during bootstrap Juanma Barranquero
2013-07-09 15:54 ` Glenn Morris
2013-07-09 15:56   ` Juanma Barranquero
2013-07-15 11:36   ` Juanma Barranquero
2013-07-15 16:10     ` Glenn Morris
2013-07-15 16:23       ` Juanma Barranquero
2013-07-15 19:48         ` Glenn Morris
2013-07-15 19:50           ` Juanma Barranquero
2013-07-16  0:19           ` Stefan Monnier
2013-07-16  1:37             ` Glenn Morris
2013-07-16  8:57               ` Stefan Monnier [this message]
2013-07-16 17:12                 ` Glenn Morris
2013-07-22 20:40                   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvoba2dgu7.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=14831@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).