From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 15200@debbugs.gnu.org
Subject: bug#15200: isearch-other-meta-char and shift
Date: Mon, 16 Sep 2013 22:19:02 -0400 [thread overview]
Message-ID: <jwvob7sjiu1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87txhko1mb.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 17 Sep 2013 01:09:36 +0300")
> This happens after this code:
> (memq scroll-command
> '(universal-argument
> negative-argument digit-argument))))))
> (command-execute scroll-command)
This code can be simplified as follows: `scroll-command' can be removed,
instead its value is immediately available as `this-command'.
> Perhaps `command-execute' should be removed here.
Indeed. For isearch-allow-prefix, that's all that's needed.
> It's not yet removed in this patch since I'm not sure
> because after moving its post-processing code:
> (let ((ab-bel (isearch-string-out-of-window isearch-point)))
> (if ab-bel
> (isearch-back-into-window (eq ab-bel 'above) isearch-point)
> (goto-char isearch-point)))
Yes, this needs to be moved to post-command-hook.
Another alternative is to do something like
(setq this-command
`(lambda () (interactive)
(let ((isearch-point (point)))
(command-execute ',this-command)
(let ((ab-bel (isearch-string-out-of-window isearch-point)))
(if ab-bel
(isearch-back-into-window (eq ab-bel 'above) isearch-point)
(goto-char isearch-point))))))
but this is probably going to bring us more trouble than it's worth.
Stefan
next prev parent reply other threads:[~2013-09-17 2:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 16:28 bug#15200: isearch-other-meta-char and shift Juri Linkov
2013-08-27 16:45 ` Juri Linkov
2013-08-28 0:27 ` Stefan Monnier
2013-08-28 16:42 ` Juri Linkov
2013-08-28 18:33 ` Stefan Monnier
2013-08-29 6:49 ` Juri Linkov
2013-08-29 12:30 ` Stefan Monnier
2013-09-01 18:45 ` Juri Linkov
2013-09-03 2:12 ` Stefan Monnier
2013-09-03 2:22 ` Drew Adams
2013-09-16 22:09 ` Juri Linkov
2013-09-17 1:21 ` Stefan Monnier
2013-09-17 2:19 ` Stefan Monnier [this message]
2013-10-07 23:35 ` Juri Linkov
2013-10-08 3:07 ` Stefan Monnier
2013-10-08 23:29 ` Juri Linkov
2013-10-09 2:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob7sjiu1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15200@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).