From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17210: 24.3.50; help mode [back] link to a C-h b keybind listing fails with message "Current buffer is not in Help mode" Date: Mon, 07 Apr 2014 14:17:00 -0400 Message-ID: References: <5341E798.4060004@iankelling.org> <5342585B.9070603@gmx.at> <83ob0d6sow.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396894711 7229 80.91.229.3 (7 Apr 2014 18:18:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Apr 2014 18:18:31 +0000 (UTC) Cc: ian@iankelling.org, 17210@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 07 20:18:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXE7i-00029B-KW for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 20:18:22 +0200 Original-Received: from localhost ([::1]:36085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXE7i-00083f-5D for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Apr 2014 14:18:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXE7Y-00080Z-Kh for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 14:18:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXE7O-0007cD-Rj for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 14:18:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXE7O-0007bz-OX for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WXE7O-0000T9-3o for bug-gnu-emacs@gnu.org; Mon, 07 Apr 2014 14:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Apr 2014 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17210 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17210-submit@debbugs.gnu.org id=B17210.13968946261725 (code B ref 17210); Mon, 07 Apr 2014 18:18:02 +0000 Original-Received: (at 17210) by debbugs.gnu.org; 7 Apr 2014 18:17:06 +0000 Original-Received: from localhost ([127.0.0.1]:39843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXE6T-0000Rl-Q3 for submit@debbugs.gnu.org; Mon, 07 Apr 2014 14:17:06 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48656) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXE6Q-0000RS-HW for 17210@debbugs.gnu.org; Mon, 07 Apr 2014 14:17:03 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s37IH0YJ026594; Mon, 7 Apr 2014 14:17:00 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 65E0660115; Mon, 7 Apr 2014 14:17:00 -0400 (EDT) In-Reply-To: <83ob0d6sow.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Apr 2014 18:54:39 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered LNG_SB_1=0.2, RV4905=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4905> : inlines <695> : streams <1153533> : uri <1723180> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87858 Archived-At: > Can you tell why you replaced a literal "*Help*" with a call to > help-buffer? I think it's just generally preferable. > That change was part of your pixel-resizing changes, but > it doesn't sound related to me, and the ChangeLog entry doesn't > provide any explanations to convince me otherwise. > Also, describe-bindings-internal is only called from this single > place, so I see no reason to support some other help buffers. Do you? You might have done M-x rename-uniquely. Does the patch below help? Stefan === modified file 'lisp/help.el' --- lisp/help.el 2014-04-05 18:33:55 +0000 +++ lisp/help.el 2014-04-07 18:16:00 +0000 @@ -485,8 +485,11 @@ (or buffer (setq buffer (current-buffer))) (help-setup-xref (list #'describe-bindings prefix buffer) (called-interactively-p 'interactive)) - (with-current-buffer buffer - (describe-bindings-internal nil prefix))) + (with-help-window (help-buffer) + ;; Be aware that `describe-buffer-bindings' puts its output into + ;; the current buffer. + (with-current-buffer (help-buffer) + (describe-buffer-bindings buffer prefix)))) ;; This function used to be in keymap.c. (defun describe-bindings-internal (&optional menus prefix) @@ -497,6 +500,7 @@ \(Ordinarily these are omitted from the output.) The optional argument PREFIX, if non-nil, should be a key sequence; then we display only bindings that start with that prefix." + (declare (obsolete describe-buffer-bindings "24.4")) (let ((buf (current-buffer))) (with-help-window (help-buffer) ;; Be aware that `describe-buffer-bindings' puts its output into